[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 0/5] added config items and deleted unused code
From:       Mike Frysinger <vapier () gentoo ! org>
Date:       2012-11-29 20:05:24
Message-ID: 201211291505.25531.vapier () gentoo ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 16 November 2012 13:36:29 manuel.f.zerpies@ww.stud.uni-erlangen.de 
wrote:
> From: Manuel Zerpies <manuel.f.zerpies@ww.stud.uni-erlangen.de>
> 
> I was looking at some pieces of the code and came across some comments
> saying "we have no config item named like this" or "this should be
> configurable", so I implemented the Kconfig parts to make those parts
> configurable.
> 
> In one case I found code, that will never be executed, due to the fact
> that the item is always defined at the beginning of the file and never
> changes its value during the file. At some point after that, we check
> whether the item is not defined. It is always defined at this point, so I
> removed the code.

you need to add signed-off-by tags to your commits

also, if you're going to bump a patchset, you don't need to ping every patch 
in the set
-mike

["signature.asc" (application/pgp-signature)]

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]