[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [PATCH] Tar tests fail if external bunzip2 not installed
From:       Antonio Diaz Diaz <ant_diaz () teleline ! es>
Date:       2012-11-29 13:35:08
Message-ID: 50B7648C.9080507 () teleline ! es
[Download RAW message or body]

package: busybox
version: snapshot 2012-11-25


Hello all,

When I run "make check" several tests fail. I think I have fixed two of 
them:

FAIL: tar_with_link_with_size
FAIL: tar_with_prefix_fields

The problem is both tests are calling plain bunzip2 instead of "busybox 
bunzip2". I have no bunzip2 installed in my machine, so the tests fail.

I attach a (trivial) patch solving this.


Best regards,
Antonio.


["busybox_test_bunzip2.patch" (text/x-diff)]

diff -urdN busybox.old/testsuite/tar/tar_with_link_with_size \
                busybox.new/testsuite/tar/tar_with_link_with_size
--- busybox.old/testsuite/tar/tar_with_link_with_size	2012-11-13 19:26:53.000000000 \
                +0100
+++ busybox.new/testsuite/tar/tar_with_link_with_size	2012-11-29 13:22:32.000000000 \
+0100 @@ -27,5 +27,5 @@
 
 export TZ=UTC-2
 
-t=`tar1_bz2 | bunzip2 | busybox tar tvf -`
+t=`tar1_bz2 | busybox bunzip2 | busybox tar tvf -`
 test x"$res1" = x"$t"
diff -urdN busybox.old/testsuite/tar/tar_with_prefix_fields \
                busybox.new/testsuite/tar/tar_with_prefix_fields
--- busybox.old/testsuite/tar/tar_with_prefix_fields	2012-11-13 19:26:53.000000000 \
                +0100
+++ busybox.new/testsuite/tar/tar_with_prefix_fields	2012-11-29 13:24:56.000000000 \
+0100 @@ -251,14 +251,14 @@
 
 # Case 1: long name, with path in prefix field
 res1='-rw-r--r-- fm3/users      9869 2007-03-12 10:44:54 \
VirtualBox-1.5.6_OSE/src/libs/xpcom18a4/ipc/ipcd/extensions/transmngr/public/ipcITransactionService.idl'
                
-t=`tar1_bz2 | bunzip2 | busybox tar tvf -`
+t=`tar1_bz2 | busybox bunzip2 | busybox tar tvf -`
 test x"$res1" = x"$t"
-t=`tar1_bz2 | bunzip2 | busybox tar tv`
+t=`tar1_bz2 | busybox bunzip2 | busybox tar tv`
 test x"$res1" = x"$t"
 
 # Case 2: long dir name, with ENTIRE path in prefix field (name = "")
 res2='drwxr-xr-x fm3/users         0 2008-02-19 16:33:20 \
VirtualBox-1.5.6_OSE/src/VBox/Additions/linux/x11include/4.3/programs/Xserver/hw/xfree86/xf24_32bpp/'
                
-t=`tar2_bz2 | bunzip2 | busybox tar tvf -`
+t=`tar2_bz2 | busybox bunzip2 | busybox tar tvf -`
 test x"$res2" = x"$t"
-t=`tar2_bz2 | bunzip2 | busybox tar tv`
+t=`tar2_bz2 | busybox bunzip2 | busybox tar tv`
 test x"$res2" = x"$t"



_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]