[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 04/19] trylink: fix linking when /bin/sh is not bash
From:       Florian Fainelli <florian () alphacore ! org>
Date:       2012-09-27 8:19:28
Message-ID: 3438548.DnsyjAK2M7 () flexo
[Download RAW message or body]

On Tuesday 25 September 2012 17:44:54 walter harms wrote:
> 
> Am 25.09.2012 15:07, schrieb Michael Tokarev:
> > On 25.09.2012 16:06, Florian Fainelli wrote:
> >> From: Nicolas Thill <nico@openwrt.org>
> >>
> >> See https://dev.openwrt.org/ticket/1115 for background on this issue.
> >>
> >> Signed-off-by: Nicolas Thill <nico@openwrt.org>
> >> ---
> >>  scripts/trylink |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/scripts/trylink b/scripts/trylink
> >> index a8b0b2e..ddada7a 100755
> >> --- a/scripts/trylink
> >> +++ b/scripts/trylink
> >> @@ -1,4 +1,4 @@
> >> -#!/bin/sh
> >> +#!/usr/bin/env bash
> > 
> > I think it's better to fix the script itself than to require bash.
> > Just IMHO anyway.
> > 
> > BTW, on my dash (0.5.7) it appears to work fine.
> > 
> 
> 
> You can also use /bin/sh as the basic requirement is a posix environment.

Just like patch 11 of this serie, I suppose that this is no longer required, I 
will double check.
--
Florian
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]