[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 19/19] scripts/kconfig/mconf: fix build error on Mac OSX
From:       Florian Fainelli <florian () alphacore ! org>
Date:       2012-09-27 8:24:02
Message-ID: 13246916.Lh5HiWQjgX () flexo
[Download RAW message or body]

On Tuesday 25 September 2012 17:02:34 Michael Tokarev wrote:
> On 25.09.2012 16:06, Florian Fainelli wrote:
> > From: Felix Fietkau <nbd@openwrt.org>
> > 
> > SIGWINCH is not defined for this platform, provide a definition of it if
> > needed.
> > 
> > Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> > ---
> >  scripts/kconfig/mconf.c |    4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> > index 1b0b6ab..84d7662 100644
> > --- a/scripts/kconfig/mconf.c
> > +++ b/scripts/kconfig/mconf.c
> > @@ -27,6 +27,10 @@
> >  #include <unistd.h>
> >  #include <locale.h>
> >  
> > +#ifndef SIGWINCH
> > +#define SIGWINCH 28
> > +#endif
> 
> Isn't it better to #ifdef the relevant code instead
> of defining something which will never be used or
> may even clash with some other signal?

Probably yes, will update the patch.
--
Florian
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]