[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: 2 patchs from SliTaz
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2011-09-13 16:40:52
Message-ID: CAK1hOcM-jXa1kdg8Y3yszEBQjHyWU1vuo1D5020fJPFVNzFfHQ () mail ! gmail ! com
[Download RAW message or body]

On Tue, Aug 16, 2011 at 8:40 PM, Pascal Bellard
<pascal.bellard@ads-lu.com> wrote:
> Hello,
>
> 1- Shrink tac using sed code.
>   text data bss dec hex filename
>    301    0   0 301 12d coreutils.org/tac.o
>     94    0   0  94  5e coreutils/tac.o
> http://hg.slitaz.org/wok-undigest/raw-file/ab174b8168e7/busybox/stuff/busybox-1.19-tac.u

Numerous problems with this patch:

(1)
  CC      coreutils/tac.o
cc1: warnings being treated as errors
coreutils/tac.c: In function 'tac_main':
coreutils/tac.c:40: error: assignment discards qualifiers from pointer
target type
coreutils/tac.c:45: error: implicit declaration of function 'sed_main'
make[1]: *** [coreutils/tac.o] Error 1

(2) unfreed malloc data in sed_main will make memory usage grow
with "tac <many files>" invocation.

(3) tac is NOEXEC, sed isn't. Calling sed_main from tac_mian is unsafe


> 2- Conspy: add framebuffer support, shrink
>   text data bss  dec hex filename
>   2570    0   0 2570 a0a miscutils.org/conspy.o
>   2514 0 0 2514 9d2 miscutils/conspy.o
> http://hg.slitaz.org/wok-undigest/raw-file/ab174b8168e7/busybox/stuff/busybox-1.19-conspy.u

It also had some problematic parts.
I fixed it up and just committed it to git.

-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]