[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: "Strange" patch in Git?
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2011-09-13 16:34:32
Message-ID: CAK1hOcMqhRZpmQnaWCz4QYeLcubNjXx68cy_MAs6RLjOdBaJyw () mail ! gmail ! com
[Download RAW message or body]

On Tue, Sep 13, 2011 at 3:38 PM, Rich Felker <dalias@aerifal.cx> wrote:
> On Tue, Sep 13, 2011 at 03:02:29PM +0200, Bernhard Reutner-Fischer wrote:
>> On Sun, Sep 11, 2011 at 01:32:36PM +0200, Matthias Andree wrote:
>> >I see this recently changed in shell/hush.c:
>> >
>> >-# if defined MAX_HISTORY && MAX_HISTORY > 0 && ENABLE_HUSH_SAVEHISTORY
>> >+# if MAX_HISTORY > 0 && ENABLE_HUSH_SAVEHISTORY
>> >
>> >Is it guaranteed that MAX_HISTORY is always defined?
>>
>> AFAICR yes (see include/libbb.h).
>
> It doesn't matter; an undefined symbol in #if gets replaced by the
> preprocessor with the token 0. The only danger is that MAX_HISTORY
> might be defined with an empty definition or non-parsable definition,
> but that would be a bug in whatever code/script defined it.

bbox is built with gcc options to warn on undefined constants -
There were bugs when constant name had a typo.

-- 
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]