[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] printf: fix exit code for %c and %s
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2009-06-26 22:11:33
Message-ID: 1158166a0906261511q23d9656dp1c767e1112f161ce () mail ! gmail ! com
[Download RAW message or body]

On Thu, Jun 25, 2009 at 9:05 PM, Colin Watson<cjwatson@ubuntu.com> wrote:
> print_direc needs to reset errno on entry, as some paths (those for %c
> and %s) don't go through multiconvert and thus don't reset errno there.
> This was showing up as a test suite failure:
>
>  FAIL: printf understands %s '"x' "'y" "'zTAIL"
>
> (I discovered this because one of the core components of the
> Debian/Ubuntu installer relies on printf in a 'set -e' script, and so
> the installer ended up completely non-functional.)
>
> Signed-off-by: Colin Watson <cjwatson@ubuntu.com>

Applied, thanks.

However I failed to reproduce the failure both on uclibc and glibc...
What libc do you use?
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]