[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] Integrate dd ibs/obs patch
From:       Rob Landley <rob () landley ! net>
Date:       2006-05-31 23:24:49
Message-ID: 200605311924.49972.rob () landley ! net
[Download RAW message or body]

On Tuesday 30 May 2006 5:42 pm, Paul Fox wrote:
> rob landley wrote:
>  > On Tuesday 16 May 2006 4:50 am, Rob Sullivan wrote:
>  > > The attached patch adds ibs= and obs= support to dd, based on the
>  > > patch in the patches/ subdirectory. It makes the feature optional, as
>  > > requested a while ago.
>  >
>  > Hmmm...  If somebody specifies both obs= and bs= they can cause the size
>  > to be something that the !twobufs_flag codepath doesn't expect.  I'll
>  > fix it.  (And the #ifdefs are going away; The !twobufs_flag codepath
>  > should be the same whether the twobufs part is enabled or not.)
>  >
>  > conv= should be under this config flag as well.
>
> i don't understand the last part of this change.
>
> why are the "notrunc" and "noerror" conv options conditional on
> the FEATURE_DD_IBS_OBS?

Basically using it as a DD_BIG switch?

> i can separate them, if it's the right thing -- i have another
> conv= option i'd like to add, and it's definitely independent of
> ibs/obs, so i need to clean this up for my own use in any case.

I'm not _against_ adding configuration granularity, but it seems like it's 
about time to add a CONFIG_NITPICK switch.

I just did so.

Be afraid.  Be very afraid...

Rob
-- 
Never bet against the cheap plastic solution.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]