[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] remove long options from hdparm + minor bugfixes
From:       Tito <farmatito () tiscali ! it>
Date:       2006-05-31 23:18:36
Message-ID: 200606010118.37009.farmatito () tiscali ! it
[Download RAW message or body]

On Thursday 1 June 2006 00:53, Rob Landley wrote:
> On Wednesday 31 May 2006 6:03 pm, Tito wrote:
> > Hi to all,
> > this patch:
> > 1)	removes totally long option support from hdparm,
> > 	but the --Istdin functionality is preserved because now the program
> > 	reads from stdin if no device names are specified:
> >
> > 	cat /proc/ide/hda/identify |./busybox hdparm
> 
> Hmmm...  The hdparm people are used to dumps its --help when you run it 
> without arguments.

They will wonder why the program blocks... ;-P
hit Ctrl-c
do hdparm -h
and discover the truth!!!

> Could you stick in a check for stdin isn't a TTY? 

I could, but our menuconfig system and the verbose usage describe the non standard behaviour,
so maybe it is not worth the trouble....

Ciao,
Tito
> > 2) fixes the handling of -h.
> > 3) fixes usage.h to match the current behaviour.
> > 4) probably reduces size (i forgot to save the reference binary...).
> >
> > The patch is tested and seems to work.
> > Please apply, if you like it.
> 
> Applied.
> 
> Rob
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]