[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] split fdisk.c
From:       Rob Landley <rob () landley ! net>
Date:       2006-02-28 6:49:37
Message-ID: 200602280149.37318.rob () landley ! net
[Download RAW message or body]

On Monday 27 February 2006 9:49 am, Denis Vlasenko wrote:
> Hi,
>
> This patch removes aix/osf/sgi/sun related code from fdisk.c
> into fdisk_aix.c etc. These files are included from fdisk.c,
> like this:

The approach I prefer (and that Garrett is trying right now) is to start over 
from a small minimal fdisk implementation that just handles standard PC 
partitions (both primary and extended), add BSD partition support on top of 
that, and then wait for requests for additional functionality from people who 
actually need it.

Trimming down the big one has three problems:

1) It's actually _more_ work than starting over.

2) Do we have any way to test that we're doing Sun, OSF, AIX, or SGI disk 
labels right?

3) This code recently had licensing concerns raised about it, and although 
those concerns are almost certainly invalid, in the 1.2 timeframe I'd prefer 
to replace that code with fresh implementations anyway.  (Especially since 
there's serious room for improvement in such a rewrite.)

That said, your split-up is a good base for adding something like OSF label 
support back in if somebody actually turns out to need it...

Rob
-- 
Never bet against the cheap plastic solution.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]