[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [CFT][patch] buildsys touch-up and standalone applets
From:       Mike Frysinger <vapier () gentoo ! org>
Date:       2006-02-28 6:24:40
Message-ID: 200602280124.40636.vapier () gentoo ! org
[Download RAW message or body]

some nitpicky stuff from just glancing at the patch ...

+  export LD_LIBRARY_PATH="$(pwd)"
+  ./busybox

the quoting is unnecessary, and generally `` is more portable than $() ...

+top_srcdir:=$(shell cd $(dir $(firstword $(MAKEFILE_LIST))) && /bin/pwd)
+    PACKAGE_OUTPUTDIR := $(shell cd $(O) && /bin/pwd)

is the absolute path a good idea ?

+ifdef V
+  ifeq ("$(origin V)", "command line")

do you really need to check that it came from the command line ?  also, might 
be nice to have this just before that:
+ifdef VERBOSE
+ V := $(VERBOSE)
+endif

+# Workaround for bugs in make-3.80
+# eval is broken if it is in a conditional

patch for the issue is here in case anyone cares:
http://viewcvs.gentoo.org/sys-devel/make/files/make-3.80-conditional-eval.patch

 CROSS           =$(subst ",, $(strip $(CROSS_COMPILER_PREFIX)))
+#")
 CC             = $(CROSS)gcc

what's the point of that additional line ?

+SED            = sed
+AWK            = awk

s/=/:=/

+# generic rules
+%.o:  %.c ; $(compile.c)

you should add some rules for %.i and %.s generation too ;)
-mike
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]