[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    RE: [BusyBox] [PATCH] minor bug in devfsd.c
From:       farmatito () tiscali ! it
Date:       2004-01-31 18:25:50
Message-ID: 400CE0E10001BC18 () mail-5 ! tiscali ! it
[Download RAW message or body]


>-- Messaggio Originale --
>From: "Chuck Meade" <chuckmeade@mindspring.com>
>To: "Tito" <farmatito@tiscali.it>,
>	<busybox@mail.busybox.net>
>Subject: RE: [BusyBox] [PATCH] minor bug in devfsd.c
>Date: Sat, 31 Jan 2004 12:11:46 -0500
>
>
>> -----Original Message-----
> From: busybox-bounces@mail.busybox.net
> [mailto:busybox-bounces@mail.busybox.net]On Behalf Of Tito
> Sent: Saturday, January 31, 2004 10:40 AM
> To: busybox@mail.busybox.net
> Subject: [BusyBox] [PATCH] minor bug in
>devfsd.c
> 
> 
> Hi to all,
> just today I discovered a minor bug in bb's devfsd that slipped through
> until now.
> The patch is simple.
> Please apply.
> 
> Ciao,
> Tito
> 
> --- miscutils/devfsd_old.c	2004-01-31 15:28:38.000000000 +0000

>> +++ miscutils/devfsd.c	2004-01-31 15:28:50.000000000 +0000
> @@ -837,7 +837,7 @@
>  	/*  Discard lookups on "/dev/log" and "/dev/initctl"  */
>  	if(   info->type == DEVFSD_NOTIFY_LOOKUP &&
>  		((info->devname[0]=='l' && info->devname[1]=='o' &&
>
> -		  info->devname[2]=='g' && !info->devname[3]) &&
> +		  info->devname[2]=='g' && !info->devname[3]) ||
>  		( info->devname[0]=='i' && info->devname[1]=='n' &&
>  		  info->devname[2]=='i' && info->devname[3]=='c' &&
>  		  info->devname[4]==
>t' && info->devname[5]=='l' && !info->devname[6])))

Unless I misread what you submitted here, the first test
is for "log" and the second test is for "inictl", which
definitely does not match the comment directly above it.
Something here needs to 
>e fixed.  My problem is not with
you changing the "and" to an "or" in your patch, it is a
problem with the contents of the second string not matching
the comment above it.

Chuck Meade

I overlooked this, i'll post a new patch as soon as possble,
so don't apply the patch until then.

Tito



__________________________________________________________________
Tiscali ADSL SENZA CANONE:
Attivazione GRATIS, contributo adesione GRATIS, modem GRATIS,
50 ore di navigazione GRATIS.  ABBONARTI TI COSTA SOLO UN CLICK!
http://point.tiscali.it/adsl/index.shtml



_______________________________________________
busybox mailing list
busybox@mail.busybox.net
http://codepoet.org/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]