[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bluesmoke-devel
Subject:    [RFC] AMD Rev F amd64_edac driver initialization
From:       Keith Mannthey <kmannth () us ! ibm ! com>
Date:       2008-11-04 22:42:36
Message-ID: 1225838556.19816.23.camel () keith-laptop
[Download RAW message or body]

This patch is required to let the rev F machines work with the latest
amd64_edac driver.  Basically, it reorders the driver to determine
the node type earlier in the initialization process.  With out this
patch the first cpu does not use the correct type and leads to improper
initialization on rev F.  

Submitted-by: Keith Mannthey <kmannth@us.ibm.com>
Signed-off-by: Vernon Mauery <vernux@us.ibm.com>

--- linux-2.6.24.7.x86_64/drivers/edac/amd64_edac.c	2008-09-25 21:13:32.000000000 -0400
+++ linux-2.6.24.7.x86_64--orig/drivers/edac/amd64_edac.c	2008-09-25 18:42:32.000000000 -0400
@@ -6516,6 +6517,13 @@
 		goto exit_now;
 	}

+	/* Determine CPU Rev of each CPU. On
+	 * Rev E and earlier we have to do the CPUID instruction.
+	 * Rev F and later we could just do a dword read from
+	 * Function 3 Offset FCh
+	 */
+	build_node_revision_table();
+
 	/* get the index of this MC */
 	pvt->mc_node_id = get_mc_node_id_from_pdev(dram_f2_ctl);

@@ -6544,14 +6552,7 @@
 		rc = -ENODEV;
 		goto exit_release_devices;
 	}
-
-	/* Determine CPU Rev of each CPU. On
-	 * Rev E and earlier we have to do the CPUID instruction.
-	 * Rev F and later we could just do a dword read from
-	 * Function 3 Offset FCh
-	 */
-	build_node_revision_table();
-
+	
 	/* IS ECC enabled? An abort point */
 	rc = amd64_check_ecc_enabled(pvt);
 	if (rc)





-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
bluesmoke-devel mailing list
bluesmoke-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluesmoke-devel
[prev in list] [next in list] [prev in thread] [next in thread]