[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bacula-devel
Subject:    Re: [Bacula-devel] Bat peformance improvement
From:       Dirk Bartley <dbartley () schupan ! com>
Date:       2007-09-25 12:19:51
Message-ID: 1190722791.29609.8.camel () srvalum2 ! schupan ! com
[Download RAW message or body]

Hello Chris

I've been quite busy attempting to paint my house.  I'll see if I can
get the opportunity soon to review these changes.  Most likely, there
will have no issue with incorporating them into the svn.

In terms of performance, I found that most of the issue was with getting
the results of the query from the database.  See the help in the latest
svn.

All apologies.

Dirk

On Sun, 2007-09-23 at 14:25 +0100, Chris Howells wrote:
> Chris Howells wrote:
> > Hi,
> > 
> > bat is rather slow for me with loading very large backups into the 
> > restore window. I therefore did some profiling of it using KCacheGrind 
> > (which uses callgrind, part of valgrind).
> 
> Hi,
> 
> Attached is an updated patch which removes more QRegExp. The profiling 
> shows that calling QProgressBar::setText() is also *fairly* expensive;
> previously bat seemed to be doing this for every single file, which was
> quite bad. bat now only updated the progress bar for every 1000 items. 
> You won't notice any difference in terms of UI, other than it will be 
> quicker to load a job. Also I've tried to stick exactly to the existing 
> coding style which I failed a bit in the first patch :)
> 
> With this patch loading a 450GB backup (2.7million files) into bat now 
> takes 280 seconds for me, rather than 466 seconds. That's nearly a 40% 
> improvement.
> 
> If anybody can verify that the patch doesn't cause any regressions, and
> also provides a similar performance boost, I'd be grateful if it could
> go into SVN :)
> 
> The profiling stats suggest that there is still some more optimisation 
> that can be done, but these were the easy pickings.
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________ Bacula-devel mailing list \
> Bacula-devel@lists.sourceforge.net \
> https://lists.sourceforge.net/lists/listinfo/bacula-devel


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel


[prev in list] [next in list] [prev in thread] [next in thread]