[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value
From: "Diederik de Groot" <reviewboard () asterisk ! org>
Date: 2015-04-18 11:29:18
Message-ID: 20150418112918.1309.61510 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/
-----------------------------------------------------------
(Updated April 18, 2015, 1:29 p.m.)
Status
------
This change has been discarded.
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
https://issues.asterisk.org/jira/browse/ASTERISK-24917
Repository: Asterisk
Description
-------
clang's static analyzer will throw quite a number warnings / errors during \
compilation, some of which can be very helpfull in finding corner-case bugs.
clang compiler warning:-Wunused-value
Changes:
apps/app_agent_pool.c
multiple occasions where return value from ast_channel_ref and ast_channel_unref is \
not checked not used. return value from AST_LIST_REMOVE should be checked.
Possible issues with leaked logged reference (added remark)
channels/chan_iax2.c
return values from ast_callid_ref and ast_callid_unref can/should be used to update \
the pointer return value from AST_SCHED_DEL should be used to update the scheduled \
variable return value from AST_LIST_REMOVE should be checked.
channels/iax2/parser.c
return value from AST_LIST_REMOVE should be checked.
include/asterisk/stringfields.h
Quick fix to send the returned value from ast_string_field_ptr_set into the void.
Work in Progress:
There are too many sources issues with "-Wunused-value" for one person to create all \
the fixes. If we want to actually use this warning we will need a couple of extra \
hands-on.
Should we suppress "-Wunused-value" ? :
I think some of the issues pointed out by clang could be very helpfull, for example \
the "unref/ref/AST_LIST_REMOVE" changes that where needed in chan_iax2.c and \
apps/app_agent_pool.c. Some others a less interesting, for example the SCHED_DEL \
fixes.
Diffs
-----
/branches/13/include/asterisk/stringfields.h 433444
/branches/13/channels/iax2/parser.c 433444
/branches/13/channels/chan_iax2.c 433444
/branches/13/apps/app_agent_pool.c 433444
Diff: https://reviewboard.asterisk.org/r/4554/diff/
Testing
-------
Just to make it clear, this was just a sample / proposal to work through large set of \
-Wunused-value warnings return. Some of them could be interesting, others might not \
be be.
Mostly looking for a discussion about which path to follow, and see if we can divvy \
up the work a little.
Compiles / Untested / Pretty certain it contains issue because of different way of \
dealing with return value from ..._unref.
File Attachments
----------------
ASTCFLAGS="-Wno-error=unused-value" make &| grep "[-W" -B1 -A2
https://reviewboard.asterisk.org/media/uploaded/files/2015/03/28/83f2f382-9ef2-41cf-8e7a-c188c014c17e__make.report
Thanks,
Diederik de Groot
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4554/">https://reviewboard.asterisk.org/r/4554/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Diederik de Groot.</div>
<p style="color: grey;"><i>Updated April 18, 2015, 1:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24917">ASTERISK-24917</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">clang's static analyzer will throw quite a number warnings / errors \
during compilation, some of which can be very helpfull in finding corner-case bugs.
clang compiler warning:-Wunused-value
Changes:
apps/app_agent_pool.c
multiple occasions where return value from ast_channel_ref and ast_channel_unref is \
not checked not used. return value from AST_LIST_REMOVE should be checked.
Possible issues with leaked logged reference (added remark)
channels/chan_iax2.c
return values from ast_callid_ref and ast_callid_unref can/should be used to update \
the pointer return value from AST_SCHED_DEL should be used to update the scheduled \
variable return value from AST_LIST_REMOVE should be checked.
channels/iax2/parser.c
return value from AST_LIST_REMOVE should be checked.
include/asterisk/stringfields.h
Quick fix to send the returned value from ast_string_field_ptr_set into the void.
Work in Progress:
There are too many sources issues with "-Wunused-value" for one person to \
create all the fixes. If we want to actually use this warning we will need a couple \
of extra hands-on.
Should we suppress "-Wunused-value" ? :
I think some of the issues pointed out by clang could be very helpfull, for example \
the "unref/ref/AST_LIST_REMOVE" changes that where needed in chan_iax2.c \
and apps/app_agent_pool.c. Some others a less interesting, for example the SCHED_DEL \
fixes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Just to make it clear, this was just a sample / proposal to work through \
large set of -Wunused-value warnings return. Some of them could be interesting, \
others might not be be.
Mostly looking for a discussion about which path to follow, and see if we can divvy \
up the work a little.
Compiles / Untested / Pretty certain it contains issue because of different way of \
dealing with return value from ..._unref.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/include/asterisk/stringfields.h <span style="color: \
grey">(433444)</span></li>
<li>/branches/13/channels/iax2/parser.c <span style="color: \
grey">(433444)</span></li>
<li>/branches/13/channels/chan_iax2.c <span style="color: grey">(433444)</span></li>
<li>/branches/13/apps/app_agent_pool.c <span style="color: \
grey">(433444)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4554/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://reviewboard.asterisk.org/media/uploaded/files/2015/03/28/83f2f38 \
2-9ef2-41cf-8e7a-c188c014c17e__make.report">ASTCFLAGS="-Wno-error=unused-value" \
make &| grep "[-W" -B1 -A2</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic