[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality
From: "Diederik de Groot" <reviewboard () asterisk ! org>
Date: 2015-04-18 11:26:04
Message-ID: 20150418112604.32676.52790 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4550/
-----------------------------------------------------------
(Updated April 18, 2015, 1:26 p.m.)
Status
------
This change has been discarded.
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
https://issues.asterisk.org/jira/browse/ASTERISK-24917
Repository: Asterisk
Description
-------
clang's static analyzer will throw quite a number warnings / errors during \
compilation, some of which can be very helpfull in finding corner-case bugs.
clang compiler warning:--dev-mode and -Wparentheses-equality
include/asterisk/linkedlists.h:450
==================================
Got rid of the extraneous "()" in the comparison to NULL by negating the comparison
include/asterisk/vector.h:261
=============================
Removed the extraneous "()". Not particularly happy about this though as they where \
used to keep this macro encapsulated (Does however not cause any compile issues)
Another possible solutions would be to double negate the comparison !((elem) != \
(value)) which would keep everything encapsulated, but does result in a double \
negative, which is ugly as well.
main/format_cap.c:467
=====================
Removed the extraneous "()". Not particularly happy about this though as they where \
used to keep this macro encapsulated (Does however not cause any compile issues)
Another possible solutions would be to double negate the comparison !((elem)->format \
!= (value)) which would keep everything encapsulated, but does result in a double \
negative, which is ugly as well.
main/format_cap.c:492
=====================
Because of the () where removed previously, they are now needed here.
main/stasis_message_router.c:82
===============================
Removed the extraneous "()". Not particularly happy about this though as they where \
used to keep this macro encapsulated (Does however not cause any compile issues)
Another possible solutions would be to double negate the comparison \
!((elem).message_type != (value)) which would keep everything encapsulated, but does \
result in a double negative, which is ugly as well.
main/stdtime/localtime.c:197/208
================================
Removed the extraneous "()". Not particularly happy about this though as they where \
used to keep this macro encapsulated (Does however not cause any compile issues)
Another possible solutions would be to double negate the comparison !((sp)->wd[0] != \
SP_STACK_FLAG) which would keep everything encapsulated, but does result in a double \
negative, which is ugly as well.
more of the same for
====================
include/asterisk/dlinkedlists.h:422/431/469
main/astobj2_hash.c:768
---------
Maybe one of you has a better/nicer solution.
Diffs
-----
/branches/13/tests/test_linkedlists.c 433444
/branches/13/main/stdtime/localtime.c 433444
/branches/13/main/stasis_message_router.c 433444
/branches/13/main/format_cap.c 433444
/branches/13/main/astobj2_hash.c 433444
/branches/13/include/asterisk/vector.h 433444
/branches/13/include/asterisk/linkedlists.h 433444
/branches/13/include/asterisk/dlinkedlists.h 433444
Diff: https://reviewboard.asterisk.org/r/4550/diff/
Testing
-------
Thanks,
Diederik de Groot
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4550/">https://reviewboard.asterisk.org/r/4550/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Diederik de Groot.</div>
<p style="color: grey;"><i>Updated April 18, 2015, 1:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24917">ASTERISK-24917</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">clang's static analyzer will throw quite a number warnings / errors \
during compilation, some of which can be very helpfull in finding corner-case bugs.
clang compiler warning:--dev-mode and -Wparentheses-equality
include/asterisk/linkedlists.h:450
==================================
Got rid of the extraneous "()" in the comparison to NULL by negating the \
comparison
include/asterisk/vector.h:261
=============================
Removed the extraneous "()". Not particularly happy about this though as \
they where used to keep this macro encapsulated (Does however not cause any compile \
issues)
Another possible solutions would be to double negate the comparison !((elem) != \
(value)) which would keep everything encapsulated, but does result in a double \
negative, which is ugly as well.
main/format_cap.c:467
=====================
Removed the extraneous "()". Not particularly happy about this though as \
they where used to keep this macro encapsulated (Does however not cause any compile \
issues)
Another possible solutions would be to double negate the comparison \
!((elem)->format != (value)) which would keep everything encapsulated, but does \
result in a double negative, which is ugly as well.
main/format_cap.c:492
=====================
Because of the () where removed previously, they are now needed here.
main/stasis_message_router.c:82
===============================
Removed the extraneous "()". Not particularly happy about this though as \
they where used to keep this macro encapsulated (Does however not cause any compile \
issues)
Another possible solutions would be to double negate the comparison \
!((elem).message_type != (value)) which would keep everything encapsulated, but does \
result in a double negative, which is ugly as well.
main/stdtime/localtime.c:197/208
================================
Removed the extraneous "()". Not particularly happy about this though as \
they where used to keep this macro encapsulated (Does however not cause any compile \
issues)
Another possible solutions would be to double negate the comparison !((sp)->wd[0] \
!= SP_STACK_FLAG) which would keep everything encapsulated, but does result in a \
double negative, which is ugly as well.
more of the same for
====================
include/asterisk/dlinkedlists.h:422/431/469
main/astobj2_hash.c:768
---------
Maybe one of you has a better/nicer solution.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/tests/test_linkedlists.c <span style="color: \
grey">(433444)</span></li>
<li>/branches/13/main/stdtime/localtime.c <span style="color: \
grey">(433444)</span></li>
<li>/branches/13/main/stasis_message_router.c <span style="color: \
grey">(433444)</span></li>
<li>/branches/13/main/format_cap.c <span style="color: grey">(433444)</span></li>
<li>/branches/13/main/astobj2_hash.c <span style="color: grey">(433444)</span></li>
<li>/branches/13/include/asterisk/vector.h <span style="color: \
grey">(433444)</span></li>
<li>/branches/13/include/asterisk/linkedlists.h <span style="color: \
grey">(433444)</span></li>
<li>/branches/13/include/asterisk/dlinkedlists.h <span style="color: \
grey">(433444)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4550/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic