[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4528: dns: Add SRV recording parsing, sorting/weighting, and unit t
From: "Mark Michelson" <reviewboard () asterisk ! org>
Date: 2015-03-31 16:00:55
Message-ID: 20150331160055.14267.36987 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4528/#review14981
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Michelson
On March 31, 2015, 3:50 p.m., Joshua Colp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4528/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 3:50 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This change adds the following:
>
> 1. As SRV records are added to a result the information is parsed and stored away \
> in additional storage in the record. The SRV API can then be used to return this \
> information. 2. Before invoking the DNS query callback the list of records on the \
> result are sorted based on priority and weight. 3. Unit tests have been added which \
> verify the record parsing, sorting, and weighting. There are also some off nominal \
> which cover the cases when an invalid/corrupt record is received. 4. A unit test \
> has also been added to res_resolver_unbound which adds an SRV record to a zone and \
> confirms it is retrieved and parsed correctly.
>
> Diffs
> -----
>
> /trunk/tests/test_dns_srv.c PRE-CREATION
> /trunk/res/res_resolver_unbound.c 433815
> /trunk/main/dns_srv.c 433815
> /trunk/main/dns_core.c 433815
> /trunk/include/asterisk/dns_internal.h 433815
>
> Diff: https://reviewboard.asterisk.org/r/4528/diff/
>
>
> Testing
> -------
>
> Executed unit tests and confirmed they pass.
>
>
> Thanks,
>
> Joshua Colp
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4528/">https://reviewboard.asterisk.org/r/4528/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Mark Michelson</p>
<br />
<p>On March 31st, 2015, 3:50 p.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated March 31, 2015, 3:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This change adds the following:
1. As SRV records are added to a result the information is parsed and stored away in \
additional storage in the record. The SRV API can then be used to return this \
information. 2. Before invoking the DNS query callback the list of records on the \
result are sorted based on priority and weight. 3. Unit tests have been added which \
verify the record parsing, sorting, and weighting. There are also some off nominal \
which cover the cases when an invalid/corrupt record is received. 4. A unit test has \
also been added to res_resolver_unbound which adds an SRV record to a zone and \
confirms it is retrieved and parsed correctly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Executed unit tests and confirmed they pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/tests/test_dns_srv.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_resolver_unbound.c <span style="color: grey">(433815)</span></li>
<li>/trunk/main/dns_srv.c <span style="color: grey">(433815)</span></li>
<li>/trunk/main/dns_core.c <span style="color: grey">(433815)</span></li>
<li>/trunk/include/asterisk/dns_internal.h <span style="color: \
grey">(433815)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4528/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic