[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket discon
From: "Ashley Sanders" <reviewboard () asterisk ! org>
Date: 2015-03-31 15:58:25
Message-ID: 20150331155825.14267.84585 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4520/
-----------------------------------------------------------
(Updated March 31, 2015, 10:58 a.m.)
Status
------
This change has been discarded.
Review request for Asterisk Developers.
Bugs: ASTERISK-24802
https://issues.asterisk.org/jira/browse/ASTERISK-24802
Repository: testsuite
Description
-------
This review has been moved to gerrit: https://gerrit.asterisk.org/#/c/18/
When an error occurs while writing to a web socket, the web socket is disconnected \
and the event is logged. A side-effect of this, however, is that any application on \
the other side waiting for a response from Stasis is left hanging indefinitely (as \
there is no mechanism presently available for notifying interested parties about web \
socket error states in Stasis).
This patch introduces a new channel variable: STASISSTATUS to give outside \
applications context when errors occur in Stasis that interrupt normal processing.
This test exercises three scenarios to elicit updates to the STASISSTATUS channel \
variable: 1) The 'Babs' scenario: tests the situation where a channel is originated \
under normal conditions and then the channel is hungup. For this case, the test \
verifies that Stasis correctly assigns SUCCESS to STASISSTATUS.
2) The 'Bugs' scenario: tests the situation where a call is originated requesting an \
app that was never registered in Stasis to verify the 'FAILED' state is correctly \
applied. 3) The 'Buster' scenario: tests the situation where an app that was \
registered in Stasis when call A was originated (and while call A is still active) \
but is no longer registered when call B is originated. Determines if the 'FAILED' \
state is correctly applied.
***Note*** This is a test. It is only a test. The review for the Asterisk source can \
be found at: https://reviewboard.asterisk.org/r/4519/
Diffs
-----
./asterisk/trunk/tests/rest_api/applications/tests.yaml 6547
./asterisk/trunk/tests/rest_api/applications/stasisstatus/test_scenario_factory.py \
PRE-CREATION
./asterisk/trunk/tests/rest_api/applications/stasisstatus/test_scenario.py \
PRE-CREATION
./asterisk/trunk/tests/rest_api/applications/stasisstatus/test_case.py PRE-CREATION \
./asterisk/trunk/tests/rest_api/applications/stasisstatus/test-config.yaml \
PRE-CREATION
./asterisk/trunk/tests/rest_api/applications/stasisstatus/run-test PRE-CREATION
./asterisk/trunk/tests/rest_api/applications/stasisstatus/observable_object.py \
PRE-CREATION
./asterisk/trunk/tests/rest_api/applications/stasisstatus/monitor.py PRE-CREATION
./asterisk/trunk/tests/rest_api/applications/stasisstatus/configs/ast1/sip.conf \
PRE-CREATION
./asterisk/trunk/tests/rest_api/applications/stasisstatus/configs/ast1/extensions.conf \
PRE-CREATION
./asterisk/trunk/tests/rest_api/applications/stasisstatus/ari_client.py \
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4520/diff/
Testing
-------
Thanks,
Ashley Sanders
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4520/">https://reviewboard.asterisk.org/r/4520/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Ashley Sanders.</div>
<p style="color: grey;"><i>Updated March 31, 2015, 10:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24802">ASTERISK-24802</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been moved to gerrit: \
https://gerrit.asterisk.org/#/c/18/
When an error occurs while writing to a web socket, the web socket is disconnected \
and the event is logged. A side-effect of this, however, is that any application on \
the other side waiting for a response from Stasis is left hanging indefinitely (as \
there is no mechanism presently available for notifying interested parties about web \
socket error states in Stasis).
This patch introduces a new channel variable: STASISSTATUS to give outside \
applications context when errors occur in Stasis that interrupt normal processing.
This test exercises three scenarios to elicit updates to the STASISSTATUS channel \
variable: 1) The 'Babs' scenario: tests the situation where a channel is \
originated under normal conditions and then the channel is hungup. For this case, the \
test verifies that Stasis correctly assigns SUCCESS to STASISSTATUS.
2) The 'Bugs' scenario: tests the situation where a call is originated \
requesting an app that was never registered in Stasis to verify the 'FAILED' \
state is correctly applied. 3) The 'Buster' scenario: tests the situation \
where an app that was registered in Stasis when call A was originated (and while call \
A is still active) but is no longer registered when call B is originated. \
Determines if the 'FAILED' state is correctly applied.
***Note*** This is a test. It is only a test. The review for the Asterisk source can \
be found at: https://reviewboard.asterisk.org/r/4519/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>./asterisk/trunk/tests/rest_api/applications/tests.yaml <span style="color: \
grey">(6547)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/test_scenario_factory.py \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/test_scenario.py <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/test_case.py <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/run-test <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/observable_object.py \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/monitor.py <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/configs/ast1/sip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/rest_api/applications/stasisstatus/ari_client.py <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4520/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic