[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time
From: "Kevin Harwell" <reviewboard () asterisk ! org>
Date: 2014-01-31 23:16:06
Message-ID: 20140131231606.31362.69309 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3148/
-----------------------------------------------------------
(Updated Jan. 31, 2014, 5:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Bugs: ASTERISK-23038
https://issues.asterisk.org/jira/browse/ASTERISK-23038
Repository: Asterisk
Description
-------
Added a "debug" configuration option for res_pjsip that when set to "yes" enables SIP \
messages to be logged. It is specified under the "system" type.
Also updated the alembic 12.1 script to include this option as well as a few others \
that were missing. Also updated the "_adding_extensions" script in order to make the \
"id" column on the table a primary key because mysql needed it to be as such.
Diffs
-----
branches/12/res/res_pjsip_logger.c 406340
branches/12/res/res_pjsip/config_global.c 406340
branches/12/res/res_pjsip.c 406340
branches/12/include/asterisk/res_pjsip.h 406340
branches/12/contrib/ast-db-manage/config/versions/21e526ad3040_add_pjsip_debug_option.py \
PRE-CREATION branches/12/configs/pjsip.conf.sample 406340
branches/12/UPGRADE.txt 406340
branches/12/CHANGES 406340
Diff: https://reviewboard.asterisk.org/r/3148/diff/
Testing
-------
Set the "debug" option in the pjsip.conf file and observed SIP debug messages on the \
console. Also, tested the modified alembic scripts against postgres and mysql \
database servers.
Thanks,
Kevin Harwell
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3148/">https://reviewboard.asterisk.org/r/3148/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2014, 5:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23038">ASTERISK-23038</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added a "debug" configuration option for res_pjsip that when \
set to "yes" enables SIP messages to be logged. It is specified under the \
"system" type.
Also updated the alembic 12.1 script to include this option as well as a few others \
that were missing. Also updated the "_adding_extensions" script in order \
to make the "id" column on the table a primary key because mysql needed it \
to be as such.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Set the "debug" option in the pjsip.conf file and observed SIP \
debug messages on the console. Also, tested the modified alembic scripts against \
postgres and mysql database servers.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/res/res_pjsip_logger.c <span style="color: \
grey">(406340)</span></li>
<li>branches/12/res/res_pjsip/config_global.c <span style="color: \
grey">(406340)</span></li>
<li>branches/12/res/res_pjsip.c <span style="color: grey">(406340)</span></li>
<li>branches/12/include/asterisk/res_pjsip.h <span style="color: \
grey">(406340)</span></li>
<li>branches/12/contrib/ast-db-manage/config/versions/21e526ad3040_add_pjsip_debug_option.py \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/12/configs/pjsip.conf.sample <span style="color: \
grey">(406340)</span></li>
<li>branches/12/UPGRADE.txt <span style="color: grey">(406340)</span></li>
<li>branches/12/CHANGES <span style="color: grey">(406340)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3148/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic