[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3153: testsuite: Dial tests for mid-call events, after-bridge actio
From: "Matt Jordan" <reviewboard () asterisk ! org>
Date: 2014-01-31 23:05:51
Message-ID: 20140131230551.31262.27587 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3153/
-----------------------------------------------------------
(Updated Jan. 31, 2014, 5:05 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Bugs: ASTERISK-23164
https://issues.asterisk.org/jira/browse/ASTERISK-23164
Repository: testsuite
Description
-------
Mid-call events, the 'h' extension, and moving channels around during/after a Dial \
operation currently play merry hell with CDRs. As it turned out, as I was fixing \
those problems I found a couple of other bugs in Dial, so I went ahead and wrote \
these tests. This includes:
* Mid-call events (GoSub/Macro): ensure that we don't get extra CDR records; that \
the application is still Dial after dialplan execution in the final record; and that \
the dial status afterwards is the result of the GoSub/Macro \
evaluation
* After-bridge actions: This includes the F,G, and g option. Some of these are \
after-bridge, some prevent the bridge from happening in the first place. The tests \
verify that the correct dialplan actions take place, and for 12, that the expected \
CDR entries are created.
* 'h' extension execution of the peer. This should not only happen, but not create \
an extra CDR.
Diffs
-----
/asterisk/trunk/tests/apps/dial/tests.yaml 4626
/asterisk/trunk/tests/apps/dial/peer_h_exten/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/apps/dial/peer_h_exten/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/apps/dial/mid_call_events/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/apps/dial/action_post_answer/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/apps/dial/action_post_answer/party_transfer/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/apps/dial/action_post_answer/party_transfer/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/configs/ast1/extensions.conf \
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3153/diff/
Testing
-------
Tests pass with modifications to be put up on a separate review.
Thanks,
Matt Jordan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3153/">https://reviewboard.asterisk.org/r/3153/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2014, 5:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23164">ASTERISK-23164</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Mid-call events, the 'h' extension, and moving channels around \
during/after a Dial operation currently play merry hell with CDRs. As it turned out, \
as I was fixing those problems I found a couple of other bugs in Dial, so I went \
ahead and wrote these tests. This includes:
* Mid-call events (GoSub/Macro): ensure that we don't get extra CDR records; \
that the application is still Dial after dialplan execution in the final record; and \
that the dial status afterwards is the result of the GoSub/Macro \
evaluation
* After-bridge actions: This includes the F,G, and g option. Some of these are \
after-bridge, some prevent the bridge from happening in the first place. The tests \
verify that the correct dialplan actions take place, and for 12, that the expected \
CDR entries are created.
* 'h' extension execution of the peer. This should not only happen, but not \
create an extra CDR.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests pass with modifications to be put up on a separate review.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/apps/dial/tests.yaml <span style="color: \
grey">(4626)</span></li>
<li>/asterisk/trunk/tests/apps/dial/peer_h_exten/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/peer_h_exten/configs/ast1/extensions.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/mid_call_events/tests.yaml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/action_post_answer/tests.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/action_post_answer/party_transfer/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/action_post_answer/party_transfer/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3153/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic