[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Re-work building of pjproject
From: "Jason Parker" <reviewboard () asterisk ! org>
Date: 2013-01-31 21:51:28
Message-ID: 20130131215128.30140.58460 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2292/
-----------------------------------------------------------
(Updated Jan. 31, 2013, 3:51 p.m.)
Review request for Asterisk Developers.
Changes
-------
Address (maybe) Walter's comments about configure scripts on clean/dist-cle=
an.
Summary
-------
This review depends on the changes from https://reviewboard.asterisk.org/r/=
2291/
This changes the way we build pjproject. We no longer need to execute the =
top-level 'all' target. We can build individual libraries instead.
We should now be much more tolerant of build failures along the way.
Incidentally, in order to properly fix one of the major issues people were =
facing, I had to change our top-level Makefile to clean our own broken depe=
ndencies. Targets that need configure to have been run should now actually=
require configure to have been run.
Also removes a few weird workarounds that got added along the way.
This addresses bug ASTERISK-20815.
https://issues.asterisk.org/jira/browse/ASTERISK-20815
Diffs (updated)
-----
/branches/11/Makefile 380737 =
/branches/11/res/Makefile 380737 =
/branches/11/res/pjproject/aconfigure 380737 =
/branches/11/res/pjproject/aconfigure.ac 380737 =
/branches/11/res/pjproject/build/common.mak 380737 =
/branches/11/res/pjproject/build/os-auto.mak.in 380737 =
Diff: https://reviewboard.asterisk.org/r/2292/diff
Testing
-------
Many, many builds, in varying states of completeness and cleanliness.
Thanks,
Jason
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2292/">https://reviewboard.asterisk.org/r/2292/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Jason Parker.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2013, 3:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Address (maybe) Walter's comments about configure scripts on \
clean/dist-clean.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review depends on the changes from \
https://reviewboard.asterisk.org/r/2291/
This changes the way we build pjproject. We no longer need to execute the top-level \
'all' target. We can build individual libraries instead.
We should now be much more tolerant of build failures along the way.
Incidentally, in order to properly fix one of the major issues people were facing, I \
had to change our top-level Makefile to clean our own broken dependencies. Targets \
that need configure to have been run should now actually require configure to have \
been run.
Also removes a few weird workarounds that got added along the way.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Many, many builds, in varying states of completeness and \
cleanliness.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20815">ASTERISK-20815</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/Makefile <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/Makefile <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/pjproject/aconfigure <span style="color: \
grey">(380737)</span></li>
<li>/branches/11/res/pjproject/aconfigure.ac <span style="color: \
grey">(380737)</span></li>
<li>/branches/11/res/pjproject/build/common.mak <span style="color: \
grey">(380737)</span></li>
<li>/branches/11/res/pjproject/build/os-auto.mak.in <span style="color: \
grey">(380737)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2292/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic