[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review]: Adds variable length callinfo packets to skinny
From: "wedhorn" <reviewboard () asterisk ! org>
Date: 2013-01-31 21:29:01
Message-ID: 20130131212901.24308.13727 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 31, 2013, 3:12 p.m., opticron wrote:
> > /trunk/channels/chan_skinny.c, line 2437
> > <https://reviewboard.asterisk.org/r/2290/diff/3/?file=33095#file33095line2437>
> >
> > You may want to mask this instead of using multiplication and division so it's a \
> > little more clear that the two lower bits are being cleared.
This is used to prune the packet, not clear the last 2 bits. Original struct has \
char[256], this makes sure we only put as much of the char[256] on the wire as has \
data (rounded up to the next 4th byte).
- wedhorn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2290/#review7785
-----------------------------------------------------------
On Jan. 25, 2013, 1:16 p.m., wedhorn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2290/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 1:16 p.m.)
>
>
> Review request for Asterisk Developers and Brad Latus.
>
>
> Summary
> -------
>
> Add packet 0x014A (variable length call info messages) to skinny for newer \
> firmware. Plenty of unknown information but includes the equivalent functionality \
> as the fixed size callinfo packet already included.
> Only send this packet if protocol reported is >= 17.
>
>
> This addresses bug ASTERISK-20965.
> https://issues.asterisk.org/jira/browse/ASTERISK-20965
>
>
> Diffs
> -----
>
> /trunk/channels/chan_skinny.c 380057
>
> Diff: https://reviewboard.asterisk.org/r/2290/diff
>
>
> Testing
> -------
>
> Made in/out/missed calls on v17 phone, correct info displayed on call and on device \
> call logs. Checked that the old callinfo is still used when protocol is <17.
>
> Thanks,
>
> wedhorn
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2290/">https://reviewboard.asterisk.org/r/2290/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 31st, 2013, 3:12 p.m., <b>opticron</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2290/diff/3/?file=33095#file33095line2437" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/channels/chan_skinny.c</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">static void transmit_callinfo_variable(struct skinny_device *d, int instance, \
int callreference,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2437</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">req</span><span class="o">-></span><span class="n">len</span> <span \
class="o">=</span> <span class="n">req</span><span class="o">-></span><span \
class="n">len</span> <span class="o">-</span> <span class="p">((</span><span \
class="n">callinfostrleft</span> <span class="o">/</span> <span \
class="mi">4</span><span class="p">)</span> <span class="o">*</span> <span \
class="mi">4</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You may want to mask \
this instead of using multiplication and division so it's a little more clear \
that the two lower bits are being cleared.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is \
used to prune the packet, not clear the last 2 bits. Original struct has char[256], \
this makes sure we only put as much of the char[256] on the wire as has data (rounded \
up to the next 4th byte).</pre> <br />
<p>- wedhorn</p>
<br />
<p>On January 25th, 2013, 1:16 p.m., wedhorn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and Brad Latus.</div>
<div>By wedhorn.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2013, 1:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add packet 0x014A (variable length call info messages) to skinny for \
newer firmware. Plenty of unknown information but includes the equivalent \
functionality as the fixed size callinfo packet already included.
Only send this packet if protocol reported is >= 17.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Made in/out/missed calls on v17 phone, correct info displayed on call \
and on device call logs. Checked that the old callinfo is still used when protocol is \
<17.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20965">ASTERISK-20965</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(380057)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2290/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic