[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] dvossel: trunk
From:       tony () mountifield ! org (Tony Mountifield)
Date:       2011-04-28 15:07:17
Message-ID: ipbvr5$vcl$1 () softins ! clara ! co ! uk
[Download RAW message or body]

In article <4DB97AEA.4040602@asteriskdocs.org>,
Leif Madsen <leif.madsen@asteriskdocs.org> wrote:
> On 11-04-28 10:00 AM, Russell Bryant wrote:

> >>>  	case CONF_SOUND_ERROR_MENU:
> >>>  		return S_OR(custom_sounds->errormenu, "conf-errormenu");
> >>>  	case CONF_SOUND_JOIN:
> >>> - return S_OR(custom_sounds->join, "beep");
> >>> + return S_OR(custom_sounds->join, "confbridge-join");
> >>>  	case CONF_SOUND_LEAVE:
> >>> - return S_OR(custom_sounds->leave, "beeperr");
> >>> + return S_OR(custom_sounds->leave, "confbridge-leave");
> >>>  	}
> >>
> >> A very minor nit to pick, but all the other sounds have conf- as the
> >> prefix rather than confbridge-, so perhaps conf-join and conf-leave
> >> might be more consistent...
> > 
> > Good point.  +1 from me.  :-)
> > 
> 
> Actually these were named with confbridge specifically to not overlap with the
> existing conf sounds, which are more to do with MeetMe() and not ConfBridge().
> The point was made that we wanted to avoid overwriting any custom sounds other
> people may have already created.

I see the logic, but having just checked both the core and extra sounds,
there are no files already called conf-join or conf-leave, so there should
not be any conflict, should there? And all the other sounds used by
Confbridge are the standard conf-xxx sounds from Meetme anyway.

Anyway, it's no big deal to me - I just thought it might have been an
oversight.

Cheers
Tony
-- 
Tony Mountifield
Work: tony@softins.co.uk - http://www.softins.co.uk
Play: tony@mountifield.org - http://tony.mountifield.org

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]