[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] dvossel: trunk r315856
From:       Leif Madsen <leif.madsen () asteriskdocs ! org>
Date:       2011-04-28 14:34:18
Message-ID: 4DB97AEA.4040602 () asteriskdocs ! org
[Download RAW message or body]

On 11-04-28 10:00 AM, Russell Bryant wrote:
> 
> ----- Original Message -----
> > In article <E1QF8u4-0004FT-UD@wibble.digium.internal>,
> > SVN commits to the Digium repositories <svn-commits@lists.digium.com>
> > wrote:
> > > Author: dvossel
> > > Date: Wed Apr 27 12:51:53 2011
> > > New Revision: 315856
> > > 
> > > URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=315856
> > > Log:
> > > Makes the new ConfBridge join and leave sounds be used by default
> > > rather than beep and beeperr.
> > > 
> > > Modified:
> > > trunk/apps/app_confbridge.c
> > > 
> > > Modified: trunk/apps/app_confbridge.c
> > > URL:
> > > http://svnview.digium.com/svn/asterisk/trunk/apps/app_confbridge.c?view=diff&rev=315856&r1=315855&r2=315856
> > >  ==============================================================================
> > > --- trunk/apps/app_confbridge.c (original)
> > > +++ trunk/apps/app_confbridge.c Wed Apr 27 12:51:53 2011
> > > @@ -299,9 +299,9 @@
> > > 	case CONF_SOUND_ERROR_MENU:
> > > 		return S_OR(custom_sounds->errormenu, "conf-errormenu");
> > > 	case CONF_SOUND_JOIN:
> > > - return S_OR(custom_sounds->join, "beep");
> > > + return S_OR(custom_sounds->join, "confbridge-join");
> > > 	case CONF_SOUND_LEAVE:
> > > - return S_OR(custom_sounds->leave, "beeperr");
> > > + return S_OR(custom_sounds->leave, "confbridge-leave");
> > > 	}
> > 
> > A very minor nit to pick, but all the other sounds have conf- as the
> > prefix rather than confbridge-, so perhaps conf-join and conf-leave
> > might be more consistent...
> 
> Good point.  +1 from me.  :-)
> 

Actually these were named with confbridge specifically to not overlap with the
existing conf sounds, which are more to do with MeetMe() and not ConfBridge().
The point was made that we wanted to avoid overwriting any custom sounds other
people may have already created.

Leif.

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]