[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-modperl
Subject:    Makefile fix-ups with Ben-SSL-1.16 no longer needed
From:       Dan Peterson <pete () spry ! com>
Date:       1998-04-18 23:55:16
[Download RAW message or body]

I've just installed mod_perl-1.10 using:

  apache-1.2.6
  Ben-SSL-1.16
  SSLeay-0.9.0
  Solaris-2.6
  perl-5.004_04

It appears the Makefile fix-ups, to correctly determine the include
directory when compiling with Ben-SSL support, previously required, are no
longer required and in fact cause problems.  The mod_perl Makefile.PL
previously had to try to add all the SSL related flags to the
modules/perl/Makefile.  The SSLpatch includes fixes to the apache Makefile
which now take care of this.

The mod_perl Makefile.PL would read the apache Makefile and look for the
SSL_BASE line.  The bad news is, now the apache Makefile contains 2 lines
that contain SSL_BASE, and Makefile.PL picks up the second one (and
incorrect for it's purposes). The good news is, the second SSL_BASE line
is used to set-up the correct values when calling the module Makefiles
which makes the fix-ups in Makefile.PL unnecessary.

I've included a patch (below) that updates Makefile.PL to no longer do
this check.  The problem with this patch is that it will not work with
versions of Ben-SSL prior to 1.16 (at least I don't think it will).

I guess a decision needs to made if mod_perl should discontinue support of
versions of Ben-SSL prior to 1.16, or make Makefile.PL even smarter, so it
knows which version of Ben-SSL is being used and do the right thing.  My
vote would be to discontinue support for older versions.... anything to
reduce the complexity of Makefile.PL is a good thing.

PS.  I didn't do any heavy testing of this patch.  I compiled a fresh
version of apache_1.2.6.tar.gz, apache_1.2.6+ssl_1.16.tar.gz and
mod_perl-1.10.tar.gz on Solaris 2.6 and SunOS 4.1.4 using gcc 2.7.2.3 and
2.7.2.1 respectively. I didn't test any previous versions of apache,
Ben-SSL or mod_perl.

--
------------------------------------------------------------------------
 Dan Peterson               System Architect          SPRYNET
 Email: pete@spry.com       Phone: 425-957-8240       FAX: 425-957-6240
------------------------------------------------------------------------

--- Makefile.PL Fri Mar 20 19:48:05 1998
+++ Makefile.PL Sat Apr 18 15:06:01 1998
@@ -388,16 +388,10 @@
        open FH, "$APACHE_SRC/Makefile" or
            die "can't open $APACHE_SRC/Makefile $!";
        while(<FH>) {
-           $SSL_BASE  = $1 if /SSL_BASE\s*=\s*(.*)/;
            $EXTRA_CFLAGS = $1 if /CFLAGS1\s*=\s*(.*)/;
            $SSLINCS = $1 if /SSLINCS\s*=\s*(.*)/;
        }
        close FH;
-
-       if($SSL_BASE) {
-           $SSL_INCLUDE = " -I$SSL_BASE/include ";
-           $SSL_CFLAGS = "-DAPACHE_SSL $SSL_INCLUDE";
-       }

        #stronghold
        if($SSLINCS) {

[prev in list] [next in list] [prev in thread] [next in thread]