[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Help with code revision process
From:       Myriam Schweingruber <myriam () kde ! org>
Date:       2020-02-14 12:22:46
Message-ID: CAGzoOB_bxkTuAfa_bp3qHMzQezyG93zkA+nc1BOKgF6OLnOQCA () mail ! gmail ! com
[Download RAW message or body]

Hi Pedro,

On Fri, 14 Feb 2020 at 13:12, Pedro de Carvalho Gomes <
pedrogomes81@gmail.com> wrote:

> Hi,
>
> Yesterday I created three Review Requests. However only one of them has an
> associated bugtrack ID.
>

Thanks a lot for these. Did you check the bug database if those are related
to existing bugs? If yes it should be easy to add the ID to close the bugs
on commit, but it is not a hard requirement


> And none has an associated Phabricator task. Are these required for the
> review process?
>

No, not a hard requirement either.

> What's the usual procedure to submit a PR?
>

You did quite well AFAICS, now we need somebody to review the code.

FWIW: it's always good to test build to avoid breaking it o commit



-- 
Proud member of the Amarok and KDE Community
Protect your freedom and support the work of the FSFE:
http://www.fsfe.org
<http://www.fsfe.org/>
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">Hi Pedro,</div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 14 Feb 2020 at 13:12, \
Pedro de Carvalho Gomes &lt;<a \
href="mailto:pedrogomes81@gmail.com">pedrogomes81@gmail.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
dir="ltr">Hi,<div><br>Yesterday I created three Review Requests. However only one of \
them has an associated bugtrack ID.</div></div></blockquote><div><br></div><div \
class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks a lot for \
these. Did you check the bug database if those are related to existing bugs? If yes \
it should be easy to add the ID to close the bugs on commit, but it is not a hard \
requirement</div><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px \
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
dir="ltr"><div>And none has an associated Phabricator task. Are these required for \
the review process? </div></div></blockquote><div><br></div><div \
class="gmail_default" style="font-family:arial,helvetica,sans-serif">No, not a hard \
requirement either.</div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif"></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>What&#39;s the usual procedure \
to submit a PR?<br></div></div></blockquote><div><br></div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">You did quite well AFAICS, now we need \
somebody to review the code.  </div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">FWIW: it&#39;s always good to test \
build to avoid breaking it o commit</div><div>  </div></div><br \
clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div \
dir="ltr"><div><div dir="ltr"><div style="text-align:left"><div>Proud member of the \
Amarok and KDE Community</div><div>Protect your freedom and<span \
style="font-family:arial,helvetica,sans-serif"> support the work</span>  of<span \
style="font-family:arial,helvetica,sans-serif"> </span><span \
style="font-family:arial,helvetica,sans-serif">the</span>  FSFE:</div><div><a \
href="http://www.fsfe.org/" style="color:rgb(17,85,204)" \
target="_blank">http://www.fsfe.org</a><a href="http://www.fsfe.org/" \
style="color:rgb(17,85,204)" target="_blank"><br></a></div><div>Please don&#39;t send \
me proprietary file formats,</div><div>use ISO standard ODF instead (ISO/IEC \
26300)</div></div></div></div></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]