From amarok-devel  Fri Feb 14 12:22:46 2020
From: Myriam Schweingruber <myriam () kde ! org>
Date: Fri, 14 Feb 2020 12:22:46 +0000
To: amarok-devel
Subject: Re: Help with code revision process
Message-Id: <CAGzoOB_bxkTuAfa_bp3qHMzQezyG93zkA+nc1BOKgF6OLnOQCA () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=amarok-devel&m=158168299008697
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--0000000000000b4d90059e884446"

--0000000000000b4d90059e884446
Content-Type: text/plain; charset="UTF-8"

Hi Pedro,

On Fri, 14 Feb 2020 at 13:12, Pedro de Carvalho Gomes <
pedrogomes81@gmail.com> wrote:

> Hi,
>
> Yesterday I created three Review Requests. However only one of them has an
> associated bugtrack ID.
>

Thanks a lot for these. Did you check the bug database if those are related
to existing bugs? If yes it should be easy to add the ID to close the bugs
on commit, but it is not a hard requirement


> And none has an associated Phabricator task. Are these required for the
> review process?
>

No, not a hard requirement either.

> What's the usual procedure to submit a PR?
>

You did quite well AFAICS, now we need somebody to review the code.

FWIW: it's always good to test build to avoid breaking it o commit



-- 
Proud member of the Amarok and KDE Community
Protect your freedom and support the work of the FSFE:
http://www.fsfe.org
<http://www.fsfe.org/>
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)

--0000000000000b4d90059e884446
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:arial,helvetica,sans-serif">Hi Pedro,</div></div><br><div class=3D=
"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, 14 Feb 2020 at =
13:12, Pedro de Carvalho Gomes &lt;<a href=3D"mailto:pedrogomes81@gmail.com=
">pedrogomes81@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex"><div dir=3D"ltr">Hi,<div><br>Yesterday I created th=
ree Review Requests. However only one of them has an associated bugtrack ID=
.</div></div></blockquote><div><br></div><div class=3D"gmail_default" style=
=3D"font-family:arial,helvetica,sans-serif">Thanks a lot for these. Did you=
 check the bug database if those are related to existing bugs? If yes it sh=
ould be easy to add the ID to close the bugs on commit, but it is not a har=
d requirement</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><div dir=3D"ltr"><div>And none has an associated Phabricator tas=
k. Are these required for the review process? </div></div></blockquote><div=
><br></div><div class=3D"gmail_default" style=3D"font-family:arial,helvetic=
a,sans-serif">No, not a hard requirement either.</div><div class=3D"gmail_d=
efault" style=3D"font-family:arial,helvetica,sans-serif"></div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>What&#39;s the =
usual procedure to submit a PR?<br></div></div></blockquote><div><br></div>=
<div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-seri=
f">You did quite well AFAICS, now we need somebody to review the code.=C2=
=A0</div><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,=
sans-serif"><br></div><div class=3D"gmail_default" style=3D"font-family:ari=
al,helvetica,sans-serif">FWIW: it&#39;s always good to test build to avoid =
breaking it o commit</div><div>=C2=A0</div></div><br clear=3D"all"><div><br=
></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><=
div><div dir=3D"ltr"><div style=3D"text-align:left"><div>Proud member of th=
e Amarok and KDE Community</div><div>Protect your freedom and<span style=3D=
"font-family:arial,helvetica,sans-serif"> support the work</span>=C2=A0of<s=
pan style=3D"font-family:arial,helvetica,sans-serif"> </span><span style=3D=
"font-family:arial,helvetica,sans-serif">the</span>=C2=A0FSFE:</div><div><a=
 href=3D"http://www.fsfe.org/" style=3D"color:rgb(17,85,204)" target=3D"_bl=
ank">http://www.fsfe.org</a><a href=3D"http://www.fsfe.org/" style=3D"color=
:rgb(17,85,204)" target=3D"_blank"><br></a></div><div>Please don&#39;t send=
 me proprietary file formats,</div><div>use ISO standard ODF instead (ISO/I=
EC 26300)</div></div></div></div></div></div></div>

--0000000000000b4d90059e884446--