[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Review Request 128468: Allow BPM to be used by the track (re)naming tool (collection management).
From:       Michel Hermier <michel.hermier () gmail ! com>
Date:       2016-07-16 14:56:11
Message-ID: 20160716145611.28739.13789 () mimi ! kde ! org
[Download RAW message or body]

--===============7260814686873979130==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128468/
-----------------------------------------------------------

Review request for Amarok.


Repository: amarok


Description
-------

When creating/moving tracks using the internal tool, it is not possible \
currently to use the BPM information to organise the track. While all the \
all (most?) other items are available to describe the filename, this one \
was missing.


Diffs
-----

  src/dialogs/OrganizeCollectionDialog.cpp 973e9cb 
  src/dialogs/TagGuesserDialog.cpp e6c427e 
  src/dialogs/TrackOrganizer.cpp 6e793fd 
  src/widgets/FilenameLayoutWidget.h 9fb2678 
  src/widgets/FilenameLayoutWidget.cpp 8d189cf 

Diff: https://git.reviewboard.kde.org/r/128468/diff/


Testing
-------

Run tested, and the generation of file names in the collection management \
tool was successfull. (I was not able to move/copy renamed collection \
thought, probably related to another issue)


Thanks,

Michel Hermier


--===============7260814686873979130==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128468/">https://git.reviewboard.kde.org/r/128468/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Michel Hermier.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">When creating/moving tracks \
using the internal tool, it is not possible currently to use the BPM \
information to organise the track. While all the all (most?) other items \
are available to describe the filename, this one was missing.</p></pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Run tested, and the \
generation of file names in the collection management tool was successfull. \
(I was not able to move/copy renamed collection thought, probably related \
to another issue)</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/dialogs/OrganizeCollectionDialog.cpp <span style="color: \
grey">(973e9cb)</span></li>

 <li>src/dialogs/TagGuesserDialog.cpp <span style="color: \
grey">(e6c427e)</span></li>

 <li>src/dialogs/TrackOrganizer.cpp <span style="color: \
grey">(6e793fd)</span></li>

 <li>src/widgets/FilenameLayoutWidget.h <span style="color: \
grey">(9fb2678)</span></li>

 <li>src/widgets/FilenameLayoutWidget.cpp <span style="color: \
grey">(8d189cf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128468/diff/" \
style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============7260814686873979130==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic