From amarok-devel Sat Jul 16 14:56:11 2016 From: Michel Hermier Date: Sat, 16 Jul 2016 14:56:11 +0000 To: amarok-devel Subject: Review Request 128468: Allow BPM to be used by the track (re)naming tool (collection management). Message-Id: <20160716145611.28739.13789 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=amarok-devel&m=146868098305114 --===============7260814686873979130== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128468/ ----------------------------------------------------------- Review request for Amarok. Repository: amarok Description ------- When creating/moving tracks using the internal tool, it is not possible currently to use the BPM information to organise the track. While all the all (most?) other items are available to describe the filename, this one was missing. Diffs ----- src/dialogs/OrganizeCollectionDialog.cpp 973e9cb src/dialogs/TagGuesserDialog.cpp e6c427e src/dialogs/TrackOrganizer.cpp 6e793fd src/widgets/FilenameLayoutWidget.h 9fb2678 src/widgets/FilenameLayoutWidget.cpp 8d189cf Diff: https://git.reviewboard.kde.org/r/128468/diff/ Testing ------- Run tested, and the generation of file names in the collection management tool was successfull. (I was not able to move/copy renamed collection thought, probably related to another issue) Thanks, Michel Hermier --===============7260814686873979130== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128468/

Review request for Amarok.
By Michel Hermier.
Repository: amarok

Description 

When creating/moving tracks using the internal tool, it is not possible currently to use the BPM information to organise the track.
While all the all (most?) other items are available to describe the filename, this one was missing.

Testing 

Run tested, and the generation of file names in the collection management tool was successfull. (I was not able to move/copy renamed collection thought, probably related to another issue)

Diffs

  • src/dialogs/OrganizeCollectionDialog.cpp (973e9cb)
  • src/dialogs/TagGuesserDialog.cpp (e6c427e)
  • src/dialogs/TrackOrganizer.cpp (6e793fd)
  • src/widgets/FilenameLayoutWidget.h (9fb2678)
  • src/widgets/FilenameLayoutWidget.cpp (8d189cf)

View Diff
--===============7260814686873979130==--