[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/
From: "Anmol Ahuja" <darthcodus () gmail ! com>
Date: 2013-11-18 13:50:04
Message-ID: 20131118135004.2778.63892 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113389/
-----------------------------------------------------------
(Updated Nov. 18, 2013, 7:20 p.m.)
Review request for Amarok.
Changes
-------
Create a new valMultiLyrics key instead of special handling. Should I get rid of \
multiple lyrics all together?
Repository: amarok
Description
-------
Changes made to the tagging framework in shared/.
Diffs (updated)
-----
shared/MetaValues.h 4b003ed
shared/tag_helpers/APETagHelper.cpp ba39a10
shared/tag_helpers/ASFTagHelper.cpp 3439845
shared/tag_helpers/ID3v2TagHelper.h a9c9ab9
shared/tag_helpers/ID3v2TagHelper.cpp 03a3836
shared/tag_helpers/MP4TagHelper.cpp 23d8879
shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5
Diff: http://git.reviewboard.kde.org/r/113389/diff/
Testing
-------
Thanks,
Anmol Ahuja
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113389/">http://git.reviewboard.kde.org/r/113389/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2013, 7:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Create a new valMultiLyrics key instead of special handling. Should I \
get rid of multiple lyrics all together?</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changes made to the tagging framework in shared/.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>shared/MetaValues.h <span style="color: grey">(4b003ed)</span></li>
<li>shared/tag_helpers/APETagHelper.cpp <span style="color: \
grey">(ba39a10)</span></li>
<li>shared/tag_helpers/ASFTagHelper.cpp <span style="color: \
grey">(3439845)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.h <span style="color: \
grey">(a9c9ab9)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: \
grey">(03a3836)</span></li>
<li>shared/tag_helpers/MP4TagHelper.cpp <span style="color: \
grey">(23d8879)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: \
grey">(8ff52c5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113389/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic