'Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/
From:       Matěj_Laitl <matej () laitl ! cz>
Date:       2013-11-17 11:18:26
Message-ID: 20131117111826.22121.13506 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113389/#review43842
-----------------------------------------------------------

Not yet a "Skip it" from me, please answer some important questions below. I guess \
this patch could be renamed to "Add support for reading lyrics from tags", right?

shared/MetaTagLib.h
<http://git.reviewboard.kde.org/r/113389/#comment31476>

    I don't understand the need for this method. Isn't readTags() supposed to read \
lyrics and return them under Meta::valLyrics key?  
    What does this method return? Maps what to what? It would need documentation.

shared/MetaTagLib.cpp
<http://git.reviewboard.kde.org/r/113389/#comment31477>

    You leak tagHelper in this case, I propose using QScopedPointer.

    Also, I totally don't get the purpose - if ID3v2TagHelper needs special casing, \
it needs to be *inside* it.

shared/MetaValues.h
<http://git.reviewboard.kde.org/r/113389/#comment31478>

    No, please add valLyrics after valImage with value (1LL << 40) + 3;

shared/tag_helpers/ID3v2TagHelper.h
<http://git.reviewboard.kde.org/r/113389/#comment31479>

    why the need for a custom method?

- Matěj Laitl

On Oct. 22, 2013, 6:06 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113389/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2013, 6:06 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Changes made to the tagging framework in shared/.
> 
> 
> Diffs
> -----
> 
> shared/MetaTagLib.h 2de3be2 
> shared/MetaTagLib.cpp d42dd32 
> shared/MetaValues.h 4b003ed 
> shared/tag_helpers/APETagHelper.cpp ba39a10 
> shared/tag_helpers/ASFTagHelper.cpp 3439845 
> shared/tag_helpers/ID3v2TagHelper.h a9c9ab9 
> shared/tag_helpers/ID3v2TagHelper.cpp 03a3836 
> shared/tag_helpers/MP4TagHelper.cpp 23d8879 
> shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5 
> 
> Diff: http://git.reviewboard.kde.org/r/113389/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113389/">http://git.reviewboard.kde.org/r/113389/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not yet a &quot;Skip \
it&quot; from me, please answer some important questions below. I guess this patch \
could be renamed to &quot;Add support for reading lyrics from tags&quot;, \
right?</pre>  <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/113389/diff/1/?file=204526#file204526line53" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shared/MetaTagLib.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace Meta</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">53</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">AMAROKSHARED_EXPORT</span> <span class="n">QMap</span><span \
class="o">&lt;</span><span class="n">QString</span><span class="p">,</span><span \
class="n">QString</span><span class="o">&gt;</span> <span \
class="n">readAllLyrics</span><span class="p">(</span> <span class="k">const</span> \
<span class="n">QString</span> <span class="o">&amp;</span><span \
class="n">path</span> <span class="p">);</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">54</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don&#39;t \
understand the need for this method. Isn&#39;t readTags() supposed to read lyrics and \
return them under Meta::valLyrics key?

What does this method return? Maps what to what? It would need documentation.</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/113389/diff/1/?file=204527#file204527line292" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shared/MetaTagLib.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">292</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">TagHelper</span> <span class="o">*</span><span class="n">tagHelper</span> \
<span class="o">=</span> <span class="n">selectHelper</span><span class="p">(</span> \
<span class="n">fileref</span> <span class="p">);</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">293</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span><span class="p">(</span> <span class="n">tagHelper</span> <span \
class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">294</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">295</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span><span class="p">(</span> <span class="n">ID3v2TagHelper</span> \
<span class="o">*</span><span class="n">id3v2Helper</span> <span class="o">=</span> \
<span class="k">dynamic_cast</span><span class="o">&lt;</span><span \
class="n">ID3v2TagHelper</span><span class="o">*&gt;</span><span class="p">(</span> \
<span class="n">tagHelper</span> <span class="p">)</span> <span \
class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">296</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">return</span> <span class="n">id3v2Helper</span><span \
class="o">-&gt;</span><span class="n">allLyrics</span><span \
class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You leak \
tagHelper in this case, I propose using QScopedPointer.

Also, I totally don&#39;t get the purpose - if ID3v2TagHelper needs special casing, \
it needs to be *inside* it.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/113389/diff/1/?file=204528#file204528line78" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shared/MetaValues.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace Meta</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">78</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">static</span> <span class="k">const</span> <span class="n">qint64</span> \
<span class="n">valLyrics</span>       <span class="o">=</span> <span \
class="mi">1LL</span> <span class="o">&lt;&lt;</span> <span class="mi">30</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, please \
add valLyrics after valImage with value (1LL &lt;&lt; 40) + 3;</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/113389/diff/1/?file=204531#file204531line43" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shared/tag_helpers/ID3v2TagHelper.h</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace Meta</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">43</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">QMap</span><span class="o">&lt;</span><span \
class="n">QString</span><span class="p">,</span><span class="n">QString</span><span \
class="o">&gt;</span> <span class="n">allLyrics</span><span \
class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why the \
need for a custom method?</pre> </div>
<br />

<p>- Matěj Laitl</p>

<br />
<p>On October 22nd, 2013, 6:06 p.m. CEST, Anmol Ahuja wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>

<p style="color: grey;"><i>Updated Oct. 22, 2013, 6:06 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changes made to the tagging framework in shared/.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shared/MetaTagLib.h <span style="color: grey">(2de3be2)</span></li>

 <li>shared/MetaTagLib.cpp <span style="color: grey">(d42dd32)</span></li>

 <li>shared/MetaValues.h <span style="color: grey">(4b003ed)</span></li>

 <li>shared/tag_helpers/APETagHelper.cpp <span style="color: \
grey">(ba39a10)</span></li>

 <li>shared/tag_helpers/ASFTagHelper.cpp <span style="color: \
grey">(3439845)</span></li>

 <li>shared/tag_helpers/ID3v2TagHelper.h <span style="color: \
grey">(a9c9ab9)</span></li>

 <li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: \
grey">(03a3836)</span></li>

 <li>shared/tag_helpers/MP4TagHelper.cpp <span style="color: \
grey">(23d8879)</span></li>

 <li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: \
grey">(8ff52c5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113389/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 