[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 113385: GSoC 2013 Revamping Scripting - Part 2/6 : Script Manager
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2013-11-16 12:45:27
Message-ID: 20131116124527.24607.35661 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113385/#review43809
-----------------------------------------------------------
src/ScriptManager.h
<http://git.reviewboard.kde.org/r/113385/#comment31450>
Why are these functions commented out? Please remove completely if no longer used.
- Mark Kretschmann
On Oct. 22, 2013, 4:07 p.m., Anmol Ahuja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113385/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 4:07 p.m.)
>
>
> Review request for Amarok.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> Changes made to the Script Manager.
>
>
> Diffs
> -----
>
> src/ScriptItem.h PRE-CREATION
> src/ScriptItem.cpp PRE-CREATION
> src/ScriptManager.h 1a252ca
> src/ScriptManager.cpp 7e4e891
> src/ScriptUpdater.h 0e9b37d
> src/ScriptUpdater.cpp f174248
>
> Diff: http://git.reviewboard.kde.org/r/113385/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anmol Ahuja
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113385/">http://git.reviewboard.kde.org/r/113385/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113385/diff/1/?file=204457#file204457line134" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/ScriptManager.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
AMAROK_EXPORT ScriptManager : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">121</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">static</span> <span class="n">QScriptValue</span> <span \
class="nf">ScriptableServiceScript_prototype_ctor</span><span class="p">(</span> \
<span class="n">QScriptContext</span> <span class="o">*</span><span \
class="n">context</span><span class="p">,</span> <span class="n">QScriptEngine</span> \
<span class="o">*</span><span class="n">engine</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">122</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="c1"><span \
class="hl">//</span>static QScriptValue ScriptableServiceScript_prototype_ctor( \
QScriptContext *context, QScriptEngine *engine );</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why are \
these functions commented out? Please remove completely if no longer used.</pre> \
</div> <br />
<p>- Mark Kretschmann</p>
<br />
<p>On October 22nd, 2013, 4:07 p.m. UTC, Anmol Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2013, 4:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changes made to the Script Manager.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ScriptItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ScriptItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ScriptManager.h <span style="color: grey">(1a252ca)</span></li>
<li>src/ScriptManager.cpp <span style="color: grey">(7e4e891)</span></li>
<li>src/ScriptUpdater.h <span style="color: grey">(0e9b37d)</span></li>
<li>src/ScriptUpdater.cpp <span style="color: grey">(f174248)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113385/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic