From amarok-devel Sat Nov 16 12:45:27 2013 From: "Mark Kretschmann" Date: Sat, 16 Nov 2013 12:45:27 +0000 To: amarok-devel Subject: Re: Review Request 113385: GSoC 2013 Revamping Scripting - Part 2/6 : Script Manager Message-Id: <20131116124527.24607.35661 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=amarok-devel&m=138460594329339 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8630362344657711906==" --===============8630362344657711906== Content-Type: multipart/alternative; boundary="===============6108205129308556721==" --===============6108205129308556721== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113385/#review43809 ----------------------------------------------------------- src/ScriptManager.h Why are these functions commented out? Please remove completely if no longer used. - Mark Kretschmann On Oct. 22, 2013, 4:07 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113385/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2013, 4:07 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > Changes made to the Script Manager. > > > Diffs > ----- > > src/ScriptItem.h PRE-CREATION > src/ScriptItem.cpp PRE-CREATION > src/ScriptManager.h 1a252ca > src/ScriptManager.cpp 7e4e891 > src/ScriptUpdater.h 0e9b37d > src/ScriptUpdater.cpp f174248 > > Diff: http://git.reviewboard.kde.org/r/113385/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > > --===============6108205129308556721== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113385/

src/ScriptManager.h (Diff revision 1) 
class AMAROK_EXPORT ScriptManager : public QObject
121 
        static QScriptValue ScriptableServiceScript_prototype_ctor( QScriptContext *context, QScriptEngine *engine );
 122 
        //static QScriptValue ScriptableServiceScript_prototype_ctor( QScriptContext *context, QScriptEngine *engine );
 
Why are these functions commented out? Please remove completely if no longer used.

- Mark Kretschmann


On October 22nd, 2013, 4:07 p.m. UTC, Anmol Ahuja wrote:

Review request for Amarok.
By Anmol Ahuja.

Updated Oct. 22, 2013, 4:07 p.m.

Repository: amarok

Description 

Changes made to the Script Manager.

Diffs

  • src/ScriptItem.h (PRE-CREATION)
  • src/ScriptItem.cpp (PRE-CREATION)
  • src/ScriptManager.h (1a252ca)
  • src/ScriptManager.cpp (7e4e891)
  • src/ScriptUpdater.h (0e9b37d)
  • src/ScriptUpdater.cpp (f174248)

View Diff
--===============6108205129308556721==-- --===============8630362344657711906== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============8630362344657711906==--