'Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags
From:       "Mark Kretschmann" <kretschmann () kde ! org>
Date:       2013-08-30 14:46:15
Message-ID: 20130830144615.26952.82024 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112266/#review38939
-----------------------------------------------------------

Ship it!

Ship It!

- Mark Kretschmann

On Aug. 30, 2013, 1:33 p.m., Bruno Léon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112266/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 1:33 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix reading of Album Artist and Compilation tag in APE tags.
> Add support for reading Disc Number in APE tags.
> 
> 
> Diffs
> -----
> 
>   shared/tag_helpers/APETagHelper.cpp c628694 
> 
> Diff: http://git.reviewboard.kde.org/r/112266/diff/
> 
> 
> Testing
> -------
> 
> Tested with Musepack files (that do use APE tags)
> 
> 
> File Attachments
> ----------------
> 
> Taglib output
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/25/taglib_output
> 
> 
> Thanks,
> 
> Bruno Léon
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112266/">http://git.reviewboard.kde.org/r/112266/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Mark</p>

<br />
<p>On August 30th, 2013, 1:33 p.m. UTC, Bruno Léon wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Bruno Léon.</div>

<p style="color: grey;"><i>Updated Aug. 30, 2013, 1:33 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix reading of Album Artist and Compilation tag in APE tags. Add support \
for reading Disc Number in APE tags.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with Musepack files (that do use APE tags)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shared/tag_helpers/APETagHelper.cpp <span style="color: \
grey">(c628694)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112266/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/25/taglib_output">Taglib \
output</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 