--===============8186955660636537958== Content-Type: multipart/alternative; boundary="===============5654205588896661514==" --===============5654205588896661514== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/#review38939 ----------------------------------------------------------- Ship it! Ship It! - Mark Kretschmann On Aug. 30, 2013, 1:33 p.m., Bruno Léon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112266/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2013, 1:33 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Fix reading of Album Artist and Compilation tag in APE tags. > Add support for reading Disc Number in APE tags. > > > Diffs > ----- > > shared/tag_helpers/APETagHelper.cpp c628694 > > Diff: http://git.reviewboard.kde.org/r/112266/diff/ > > > Testing > ------- > > Tested with Musepack files (that do use APE tags) > > > File Attachments > ---------------- > > Taglib output > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/25/taglib_output > > > Thanks, > > Bruno Léon > > --===============5654205588896661514== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/

Ship it!

Ship It!

- Mark


On August 30th, 2013, 1:33 p.m. UTC, Bruno Léon wrote:

Review request for Amarok.
By Bruno Léon.

Updated Aug. 30, 2013, 1:33 p.m.

Description 

Fix reading of Album Artist and Compilation tag in APE tags.
Add support for reading Disc Number in APE tags.

Testing 

Tested with Musepack files (that do use APE tags)

Diffs

  • shared/tag_helpers/APETagHelper.cpp (c628694)

View Diff

File Attachments

--===============5654205588896661514==-- --===============8186955660636537958== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============8186955660636537958==--