'Re: Review Request 112044: Fixes: 322220 - Wikipedia applet shouldn't reload content if the artist/a'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 112044: Fixes: 322220 - Wikipedia applet shouldn't reload content if the artist/a
From:       "Mark Kretschmann" <kretschmann () kde ! org>
Date:       2013-08-13 7:40:13
Message-ID: 20130813074013.1122.9198 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112044/#review37645
-----------------------------------------------------------

Ship it!

Well spotted! I was wondering about this one.

- Mark Kretschmann

On Aug. 13, 2013, 6:41 a.m., Frank Meerkoetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112044/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 6:41 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch (hopefully) fixes 322220.
> 
> This (cut&paste?) error undermined the function of _checkRequireUpdate() if the \
> artist and the composer are different for a track. 
> 
> Diffs
> -----
> 
> src/context/engines/wikipedia/WikipediaEngine.cpp 0b75f15 
> 
> Diff: http://git.reviewboard.kde.org/r/112044/diff/
> 
> 
> Testing
> -------
> 
> I have tested with several mp3s where artist and composer are different, i also \
> tested with mp3s where they are the same. No unnecessary reloading for the artist \
> page was observerd.  
> 
> Thanks,
> 
> Frank Meerkoetter
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112044/">http://git.reviewboard.kde.org/r/112044/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well spotted! I was \
wondering about this one.</pre>  <br />

<p>- Mark</p>

<br />
<p>On August 13th, 2013, 6:41 a.m. UTC, Frank Meerkoetter wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Frank Meerkoetter.</div>

<p style="color: grey;"><i>Updated Aug. 13, 2013, 6:41 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch (hopefully) fixes 322220.

This (cut&amp;paste?) error undermined the function of _checkRequireUpdate() if the \
artist and the composer are different for a track. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tested with several mp3s where artist and composer are different, \
i also tested with mp3s where they are the same. No unnecessary reloading for the \
artist page was observerd. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/context/engines/wikipedia/WikipediaEngine.cpp <span style="color: \
grey">(0b75f15)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112044/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 