--===============3027716008747060407== Content-Type: multipart/alternative; boundary="===============8528107654000127030==" --===============8528107654000127030== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112044/#review37645 ----------------------------------------------------------- Ship it! Well spotted! I was wondering about this one. - Mark Kretschmann On Aug. 13, 2013, 6:41 a.m., Frank Meerkoetter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112044/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 6:41 a.m.) > > > Review request for Amarok. > > > Description > ------- > > This patch (hopefully) fixes 322220. > > This (cut&paste?) error undermined the function of _checkRequireUpdate() if the artist and the composer are different for a track. > > > Diffs > ----- > > src/context/engines/wikipedia/WikipediaEngine.cpp 0b75f15 > > Diff: http://git.reviewboard.kde.org/r/112044/diff/ > > > Testing > ------- > > I have tested with several mp3s where artist and composer are different, i also tested with mp3s where they are the same. No unnecessary reloading for the artist page was observerd. > > > Thanks, > > Frank Meerkoetter > > --===============8528107654000127030== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112044/

Ship it!

Well spotted! I was wondering about this one.

- Mark

On August 13th, 2013, 6:41 a.m. UTC, Frank Meerkoetter wrote:

Review request for Amarok.

By Frank Meerkoetter.

Updated Aug. 13, 2013, 6:41 a.m.

Description

This patch (hopefully) fixes 322220.

This (cut&paste?) error undermined the function of _checkRequireUpdate() if the artist and the composer are different for a track.

Testing

I have tested with several mp3s where artist and composer are different, i also tested with mp3s where they are the same. No unnecessary reloading for the artist page was observerd.

Diffs

src/context/engines/wikipedia/WikipediaEngine.cpp (0b75f15)

View Diff

--===============8528107654000127030==-- --===============3027716008747060407== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============3027716008747060407==--