'Review Request 112023: Disable move/copy actions for non-writeable UMS collections.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Review Request 112023: Disable move/copy actions for non-writeable UMS collections.
From:       "Frank Meerkoetter" <frank () meerkoetter ! org>
Date:       2013-08-11 20:07:35
Message-ID: 20130811200735.15599.98749 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112023/
-----------------------------------------------------------

Review request for Amarok.

Description
-------

Diffs
-----

  src/browsers/CollectionTreeView.cpp 7e93c9a 
  src/browsers/filebrowser/FileView.cpp ad200eb 
  src/core-impl/collections/umscollection/UmsCollection.h 749ff81 
  src/core-impl/collections/umscollection/UmsCollection.cpp 028966e 
  src/core/collections/Collection.h 94d24d7 
  src/core/collections/Collection.cpp 01a2e8c 

Diff: http://git.reviewboard.kde.org/r/112023/diff/

Testing
-------

I have tested with an USB-stick that is writeable and another one that is \
non-writeable. I have also observed that for the FileBrowser the "Local collection" \
is still shown as active.  

Thanks,

Frank Meerkoetter

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112023/">http://git.reviewboard.kde.org/r/112023/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Frank Meerkoetter.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tested with an USB-stick that is writeable and another one that \
is non-writeable. I have also observed that for the FileBrowser the &quot;Local \
collection&quot; is still shown as active.  </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/browsers/CollectionTreeView.cpp <span style="color: \
grey">(7e93c9a)</span></li>

 <li>src/browsers/filebrowser/FileView.cpp <span style="color: \
grey">(ad200eb)</span></li>

 <li>src/core-impl/collections/umscollection/UmsCollection.h <span style="color: \
grey">(749ff81)</span></li>

 <li>src/core-impl/collections/umscollection/UmsCollection.cpp <span style="color: \
grey">(028966e)</span></li>

 <li>src/core/collections/Collection.h <span style="color: \
grey">(94d24d7)</span></li>

 <li>src/core/collections/Collection.cpp <span style="color: \
grey">(01a2e8c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112023/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 