[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 111991: Better handling of non-writeable UMS collections
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2013-08-11 12:15:42
Message-ID: 20130811121542.12667.66211 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111991/#review37511
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Kretschmann
On Aug. 11, 2013, 11:17 a.m., Frank Meerkoetter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111991/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2013, 11:17 a.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> If an UMS-collection is non-writeable (think freshly created ext4 on an USB-stick) \
> a copy/move to collection will silently fail. It can only be seen in the debug logs \
> on the console.
> The reason is that the UMS-collection is not actually checking if its writeable. \
> Its just assuming to be always writeable.
>
> My change consists of two parts:
> 1. I check if the UMS-collection is actually writeable (mount point and if set the \
> "music folder"). 2. To give the user a hint what is going on I added a warning \
> message, informing the user that this collection is read-only (otherwise he might \
> be confused why certain operations (move/copy/organize) are missing.
>
>
> Diffs
> -----
>
> src/core-impl/collections/umscollection/UmsCollection.h 749ff81
> src/core-impl/collections/umscollection/UmsCollection.cpp 028966e
> src/core-impl/collections/umscollection/UmsCollectionLocation.cpp 1cd1ba8
>
> Diff: http://git.reviewboard.kde.org/r/111991/diff/
>
>
> Testing
> -------
>
> I have tested with an USB-Stick containing an ext4 filesystem. First i had the \
> base-dir owned by root.root (non-writeable), next i made it writeable and verified \
> that its correctly detected as such. Next i created a "Music" folder and configured \
> it for this USB-Stick. I checked that it was detected as writeable. Next i made the \
> "Music" folder non-writeable and checked that amarok also detected that.
>
> Thanks,
>
> Frank Meerkoetter
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111991/">http://git.reviewboard.kde.org/r/111991/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Mark</p>
<br />
<p>On August 11th, 2013, 11:17 a.m. UTC, Frank Meerkoetter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Frank Meerkoetter.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2013, 11:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If an UMS-collection is non-writeable (think freshly created ext4 on an \
USB-stick) a copy/move to collection will silently fail. It can only be seen in the \
debug logs on the console.
The reason is that the UMS-collection is not actually checking if its writeable. Its \
just assuming to be always writeable.
My change consists of two parts:
1. I check if the UMS-collection is actually writeable (mount point and if set the \
"music folder"). 2. To give the user a hint what is going on I added a \
warning message, informing the user that this collection is read-only (otherwise he \
might be confused why certain operations (move/copy/organize) are missing.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tested with an USB-Stick containing an ext4 filesystem. First i \
had the base-dir owned by root.root (non-writeable), next i made it writeable and \
verified that its correctly detected as such. Next i created a "Music" \
folder and configured it for this USB-Stick. I checked that it was detected as \
writeable. Next i made the "Music" folder non-writeable and checked that \
amarok also detected that.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/umscollection/UmsCollection.h <span style="color: \
grey">(749ff81)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollection.cpp <span style="color: \
grey">(028966e)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollectionLocation.cpp <span \
style="color: grey">(1cd1ba8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111991/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic