[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 111635: PlaybackConfig: add option whether playback should start on track add
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2013-07-24 16:21:39
Message-ID: 20130724162139.29402.21795 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111635/#review36451
-----------------------------------------------------------
src/configdialog/dialogs/PlaybackConfig.ui
<http://git.reviewboard.kde.org/r/111635/#comment26908>
The tooltip is too long, I think. In Amarok it is shown as one extremely long \
line. As QToolTip supports Rich Text, it might be better to break it up into \
paragraphs.
- Mark Kretschmann
On July 24, 2013, 2:41 p.m., Matěj Laitl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111635/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 2:41 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> PlaybackConfig: add option whether playback should start on track add
>
> CHANGES:
> * Added an option whether adding tracks to playlist should start playing.
>
> Also changed the entry in the 2.8 Beta ChangeLog, which is a bit strange,
> but I believe the ChangeLog is most useful for differences between major
> releases and it would be really confusing if the entry wasn't changed.
>
> BUG: 322428
> FIXED-IN: 2.8
>
>
> Diffs
> -----
>
> ChangeLog 87e4708a6330e7a612db59052a50eef053294b06
> src/amarokconfig.kcfg c9d202ad1212055f5877769c7add897547bb3f38
> src/configdialog/dialogs/PlaybackConfig.ui 2bbcba7e2b8f7fdafe98929741e9d08a069460d0 \
> src/playlist/PlaylistController.h 185b4226c171c6a1fcd5b681721e39deae2e832b
> src/playlist/PlaylistController.cpp 1d770fdff54ddc7f6bd6f5d813c377108d6f674d
>
> Diff: http://git.reviewboard.kde.org/r/111635/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matěj Laitl
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111635/">http://git.reviewboard.kde.org/r/111635/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111635/diff/2/?file=173174#file173174line36" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/configdialog/dialogs/PlaybackConfig.ui</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<string>Enable this option to start playing whenever a track or more are added \
to the playlist using mouse, pressing Enter or when the playlist is replaced. Does \
nothing if something is already playing.</string></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The tooltip \
is too long, I think. In Amarok it is shown as one extremely long line. As QToolTip \
supports Rich Text, it might be better to break it up into paragraphs.</pre> </div>
<br />
<p>- Mark</p>
<br />
<p>On July 24th, 2013, 2:41 p.m. UTC, Matěj Laitl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matěj Laitl.</div>
<p style="color: grey;"><i>Updated July 24, 2013, 2:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">PlaybackConfig: add option whether playback should start on track add
CHANGES:
* Added an option whether adding tracks to playlist should start playing.
Also changed the entry in the 2.8 Beta ChangeLog, which is a bit strange,
but I believe the ChangeLog is most useful for differences between major
releases and it would be really confusing if the entry wasn't changed.
BUG: 322428
FIXED-IN: 2.8</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: \
grey">(87e4708a6330e7a612db59052a50eef053294b06)</span></li>
<li>src/amarokconfig.kcfg <span style="color: \
grey">(c9d202ad1212055f5877769c7add897547bb3f38)</span></li>
<li>src/configdialog/dialogs/PlaybackConfig.ui <span style="color: \
grey">(2bbcba7e2b8f7fdafe98929741e9d08a069460d0)</span></li>
<li>src/playlist/PlaylistController.h <span style="color: \
grey">(185b4226c171c6a1fcd5b681721e39deae2e832b)</span></li>
<li>src/playlist/PlaylistController.cpp <span style="color: \
grey">(1d770fdff54ddc7f6bd6f5d813c377108d6f674d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111635/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic