[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 111635: PlaybackConfig: add option whether playback should start on track add
From: Matěj_Laitl <matej () laitl ! cz>
Date: 2013-07-24 14:41:03
Message-ID: 20130724144103.8095.98407 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111635/
-----------------------------------------------------------
(Updated July 24, 2013, 4:41 p.m.)
Review request for Amarok.
Changes
-------
Rebase on top of current master to fix build.
Description
-------
PlaybackConfig: add option whether playback should start on track add
CHANGES:
* Added an option whether adding tracks to playlist should start playing.
Also changed the entry in the 2.8 Beta ChangeLog, which is a bit strange,
but I believe the ChangeLog is most useful for differences between major
releases and it would be really confusing if the entry wasn't changed.
BUG: 322428
FIXED-IN: 2.8
Diffs (updated)
-----
ChangeLog 87e4708a6330e7a612db59052a50eef053294b06
src/amarokconfig.kcfg c9d202ad1212055f5877769c7add897547bb3f38
src/configdialog/dialogs/PlaybackConfig.ui 2bbcba7e2b8f7fdafe98929741e9d08a069460d0
src/playlist/PlaylistController.h 185b4226c171c6a1fcd5b681721e39deae2e832b
src/playlist/PlaylistController.cpp 1d770fdff54ddc7f6bd6f5d813c377108d6f674d
Diff: http://git.reviewboard.kde.org/r/111635/diff/
Testing
-------
Thanks,
Matěj Laitl
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111635/">http://git.reviewboard.kde.org/r/111635/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matěj Laitl.</div>
<p style="color: grey;"><i>Updated July 24, 2013, 4:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rebase on top of current master to fix build.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">PlaybackConfig: add option whether playback should start on track add
CHANGES:
* Added an option whether adding tracks to playlist should start playing.
Also changed the entry in the 2.8 Beta ChangeLog, which is a bit strange,
but I believe the ChangeLog is most useful for differences between major
releases and it would be really confusing if the entry wasn't changed.
BUG: 322428
FIXED-IN: 2.8</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: \
grey">(87e4708a6330e7a612db59052a50eef053294b06)</span></li>
<li>src/amarokconfig.kcfg <span style="color: \
grey">(c9d202ad1212055f5877769c7add897547bb3f38)</span></li>
<li>src/configdialog/dialogs/PlaybackConfig.ui <span style="color: \
grey">(2bbcba7e2b8f7fdafe98929741e9d08a069460d0)</span></li>
<li>src/playlist/PlaylistController.h <span style="color: \
grey">(185b4226c171c6a1fcd5b681721e39deae2e832b)</span></li>
<li>src/playlist/PlaylistController.cpp <span style="color: \
grey">(1d770fdff54ddc7f6bd6f5d813c377108d6f674d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111635/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic