'Re: Review Request 111038: Fixes the scrolling problem in dynamic playlists i.e. Bug 284214'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 111038: Fixes the scrolling problem in dynamic playlists i.e. Bug 284214
From:       "Commit Hook" <null () kde ! org>
Date:       2013-07-02 10:15:32
Message-ID: 20130702101532.24251.94872 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111038/#review35429
-----------------------------------------------------------

This review has been submitted with commit 9dbdb8bde9836f2e17da9ef063cea66961324639 \
by Mark Kretschmann on behalf of Vedant Agarwala to branch master.

- Commit Hook

On June 15, 2013, 11:22 a.m., Vedant Agarwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111038/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 11:22 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> After the track was changed the "scroll to current playing track" worked as per \
> user settings. But in case of dynamic playlists after the tracks were added \
> (automatically) the PrettyListView scrolled to the tracks added (i.e. it scrolled \
> to the bottom). It took me so long to figure this out and even longer to find a \
> solution; but the patch was only of 2 lines. Anyway I got a better understanding of \
> the Playlist Model-View architecture :) 
> 
> This addresses bug 284214.
> https://bugs.kde.org/show_bug.cgi?id=284214
> 
> 
> Diffs
> -----
> 
> src/playlist/view/listview/PrettyListView.cpp 8723875 
> 
> Diff: http://git.reviewboard.kde.org/r/111038/diff/
> 
> 
> Testing
> -------
> 
> Builds successfully and runs as expected
> 
> 
> Thanks,
> 
> Vedant Agarwala
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111038/">http://git.reviewboard.kde.org/r/111038/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 9dbdb8bde9836f2e17da9ef063cea66961324639 by Mark Kretschmann on \
behalf of Vedant Agarwala to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On June 15th, 2013, 11:22 a.m. UTC, Vedant Agarwala wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Vedant Agarwala.</div>

<p style="color: grey;"><i>Updated June 15, 2013, 11:22 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After the track was changed the &quot;scroll to current playing \
track&quot; worked as per user settings. But in case of dynamic playlists after the \
tracks were added (automatically) the PrettyListView scrolled to the tracks added \
(i.e. it scrolled to the bottom). It took me so long to figure this out and even \
longer to find a solution; but the patch was only of 2 lines. Anyway I got a better \
understanding of the Playlist Model-View architecture :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds successfully and runs as expected</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=284214">284214</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/playlist/view/listview/PrettyListView.cpp <span style="color: \
grey">(8723875)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111038/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 