[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2013-07-02 9:33:27
Message-ID: 20130702093327.17645.86667 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111343/#review35427
-----------------------------------------------------------
src/ScriptManager.h
<http://git.reviewboard.kde.org/r/111343/#comment25955>
Please remove the Ptr suffix from pointer members and accessors. Just name it \
m_service, service() etc.
src/scriptengine/AmarokCollectionScript.h
<http://git.reviewboard.kde.org/r/111343/#comment25956>
Looks like something is missing here?
src/scriptengine/AmarokCollectionScript.h
<http://git.reviewboard.kde.org/r/111343/#comment25958>
This should probably be const
src/scriptengine/AmarokCollectionScript.h
<http://git.reviewboard.kde.org/r/111343/#comment25959>
This should probably be const
src/scriptengine/AmarokCollectionScript.cpp
<http://git.reviewboard.kde.org/r/111343/#comment25957>
Use the KDE_DEPRECATED macro
src/scriptengine/ScriptingDefines.h
<http://git.reviewboard.kde.org/r/111343/#comment25960>
Better variable name please
- Mark Kretschmann
On July 1, 2013, 12:41 p.m., Anmol Ahuja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111343/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 12:41 p.m.)
>
>
> Review request for Amarok and Mark Kretschmann.
>
>
> Description
> -------
>
> Week 2: Added scripting interface for the collection management.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 69a8ff4
> src/ScriptManager.h afaa832
> src/ScriptManager.cpp b7f0a5c
> src/core/collections/Collection.h 7e2957d
> src/core/collections/QueryMaker.h 92b6a65
> src/scriptengine/AmarokCollectionScript.h 5733947
> src/scriptengine/AmarokCollectionScript.cpp 3fcda84
> src/scriptengine/AmarokEngineScript.h aa2b112
> src/scriptengine/AmarokEngineScript.cpp 5471838
> src/scriptengine/AmarokPlaylistScript.h 28f9d7e
> src/scriptengine/AmarokPlaylistScript.cpp 2dde634
> src/scriptengine/AmarokWindowScript.cpp c9a65ee
> src/scriptengine/MetaTypeExporter.h 031e52b
> src/scriptengine/MetaTypeExporter.cpp 5a515a6
> src/scriptengine/ScriptingDefines.h PRE-CREATION
> src/scriptengine/exporters/CollectionTypeExporter.h PRE-CREATION
> src/scriptengine/exporters/CollectionTypeExporter.cpp PRE-CREATION
> src/scriptengine/exporters/MetaTypeExporter.h PRE-CREATION
> src/scriptengine/exporters/MetaTypeExporter.cpp PRE-CREATION
> src/scriptengine/exporters/QueryMakerExporter.h PRE-CREATION
> src/scriptengine/exporters/QueryMakerExporter.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anmol Ahuja
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111343/">http://git.reviewboard.kde.org/r/111343/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111343/diff/2/?file=166938#file166938line154" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/ScriptManager.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">signals:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">152</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ScriptableServiceScript</span><span class="o">*</span> <span \
class="nf">servicePtr</span><span class="p">()</span> <span class="p">{</span> <span \
class="k">return</span> <span class="n">m_servicePtr</span><span class="p">;</span> \
<span class="p">}</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">152</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">ScriptableServiceScript</span><span class="o">*</span> <span \
class="nf">servicePtr</span><span class="p">()</span> <span class="p">{</span> <span \
class="k">return</span> <span class="n">m_servicePtr</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">data</span></span><span \
class="p"><span class="hl">()</span>;</span> <span class="p">}</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
remove the Ptr suffix from pointer members and accessors. Just name it m_service, \
service() etc.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111343/diff/2/?file=166942#file166942line60" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scriptengine/AmarokCollectionScript.h</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace AmarokScript</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">60</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * Return a</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like \
something is missing here?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111343/diff/2/?file=166942#file166942line62" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scriptengine/AmarokCollectionScript.h</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace AmarokScript</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">62</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">Collections</span><span class="o">::</span><span \
class="n">CollectionList</span> <span class="n">queryableCollections</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
probably be const</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111343/diff/2/?file=166942#file166942line63" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scriptengine/AmarokCollectionScript.h</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace AmarokScript</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">63</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">Collections</span><span class="o">::</span><span \
class="n">CollectionList</span> <span class="n">viewableCollections</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
probably be const</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111343/diff/2/?file=166943#file166943line39" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scriptengine/AmarokCollectionScript.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">39</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//deprecate</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use the \
KDE_DEPRECATED macro</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111343/diff/2/?file=166951#file166951line29" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scriptengine/ScriptingDefines.h</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QScriptValue</span> <span class="n">a</span> <span class="o">=</span> <span \
class="n">engine</span><span class="o">-></span><span \
class="n">newArray</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Better \
variable name please</pre> </div>
<br />
<p>- Mark</p>
<br />
<p>On July 1st, 2013, 12:41 p.m. UTC, Anmol Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok and Mark Kretschmann.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated July 1, 2013, 12:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Week 2: Added scripting interface for the collection management. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(69a8ff4)</span></li>
<li>src/ScriptManager.h <span style="color: grey">(afaa832)</span></li>
<li>src/ScriptManager.cpp <span style="color: grey">(b7f0a5c)</span></li>
<li>src/core/collections/Collection.h <span style="color: \
grey">(7e2957d)</span></li>
<li>src/core/collections/QueryMaker.h <span style="color: \
grey">(92b6a65)</span></li>
<li>src/scriptengine/AmarokCollectionScript.h <span style="color: \
grey">(5733947)</span></li>
<li>src/scriptengine/AmarokCollectionScript.cpp <span style="color: \
grey">(3fcda84)</span></li>
<li>src/scriptengine/AmarokEngineScript.h <span style="color: \
grey">(aa2b112)</span></li>
<li>src/scriptengine/AmarokEngineScript.cpp <span style="color: \
grey">(5471838)</span></li>
<li>src/scriptengine/AmarokPlaylistScript.h <span style="color: \
grey">(28f9d7e)</span></li>
<li>src/scriptengine/AmarokPlaylistScript.cpp <span style="color: \
grey">(2dde634)</span></li>
<li>src/scriptengine/AmarokWindowScript.cpp <span style="color: \
grey">(c9a65ee)</span></li>
<li>src/scriptengine/MetaTypeExporter.h <span style="color: \
grey">(031e52b)</span></li>
<li>src/scriptengine/MetaTypeExporter.cpp <span style="color: \
grey">(5a515a6)</span></li>
<li>src/scriptengine/ScriptingDefines.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/CollectionTypeExporter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/CollectionTypeExporter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/MetaTypeExporter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/MetaTypeExporter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/QueryMakerExporter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/QueryMakerExporter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111343/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic