'Re: Review Request 108542: Support for .opus file tags added'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 108542: Support for .opus file tags added
From:       "Commit Hook" <null () kde ! org>
Date:       2013-02-18 16:09:17
Message-ID: 20130218160917.24104.51373 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108542/#review27638
-----------------------------------------------------------

This review has been submitted with commit abd5c3ff4051c77075b39f827d58045f100a5be3 \
by Matěj Laitl on behalf of Martin Brodbeck to branch master.

- Commit Hook

On Feb. 13, 2013, 9:22 a.m., Martin Brodbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108542/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 9:22 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Support for .opus file tags added. Not sure about the mime type. Recent version of \
> taglib necessary. 
> 
> This addresses bug 312905.
> https://bugs.kde.org/show_bug.cgi?id=312905
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt f87e05e 
> shared/FileType.cpp 43d8777 
> shared/FileTypeResolver.cpp 63a83e1 
> shared/config.h.cmake 004dd57 
> shared/tag_helpers/TagHelper.cpp 4534018 
> shared/FileType.h b3d4470 
> README c49d284 
> 
> Diff: http://git.reviewboard.kde.org/r/108542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Brodbeck
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108542/">http://git.reviewboard.kde.org/r/108542/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit abd5c3ff4051c77075b39f827d58045f100a5be3 by Matěj Laitl on \
behalf of Martin Brodbeck to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On February 13th, 2013, 9:22 a.m. UTC, Martin Brodbeck wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Martin Brodbeck.</div>

<p style="color: grey;"><i>Updated Feb. 13, 2013, 9:22 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Support for .opus file tags added. Not sure about the mime type. Recent \
version of taglib necessary.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=312905">312905</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(f87e05e)</span></li>

 <li>shared/FileType.cpp <span style="color: grey">(43d8777)</span></li>

 <li>shared/FileTypeResolver.cpp <span style="color: grey">(63a83e1)</span></li>

 <li>shared/config.h.cmake <span style="color: grey">(004dd57)</span></li>

 <li>shared/tag_helpers/TagHelper.cpp <span style="color: grey">(4534018)</span></li>

 <li>shared/FileType.h <span style="color: grey">(b3d4470)</span></li>

 <li>README <span style="color: grey">(c49d284)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108542/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 