[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Some clean-up and sort
From: "Stefan Derkits" <stefan () derkits ! at>
Date: 2011-11-21 11:42:47
Message-ID: 20111121114247.23621.42694 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103195/#review8360
-----------------------------------------------------------
Ship it!
Ship It!
- Stefan Derkits
On Nov. 21, 2011, 12:38 a.m., Lucas Gomes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103195/
> -----------------------------------------------------------
> =
> (Updated Nov. 21, 2011, 12:38 a.m.)
> =
> =
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> =
> =
> Description
> -------
> =
> Sorted #includes in files related to gpodder service & playlist sync.
> Done some clean-up.
> =
> =
> Diffs
> -----
> =
> src/playlistmanager/SyncedPlaylist.h 1f37508 =
> src/playlistmanager/SyncedPlaylist.cpp 1546b7f =
> src/playlistmanager/SyncedPodcast.h ea7f517 =
> src/playlistmanager/SyncedPodcast.cpp 44a295b =
> src/playlistmanager/file/KConfigSyncRelStore.h b2f1907 =
> src/playlistmanager/file/KConfigSyncRelStore.cpp 517c6dc =
> src/services/gpodder/GpodderPodcastMeta.h 7fbad35 =
> src/services/gpodder/GpodderPodcastMeta.cpp 90bd38f =
> src/services/gpodder/GpodderPodcastRequestHandler.h 9f0ced2 =
> src/services/gpodder/GpodderPodcastTreeItem.h 96db070 =
> src/services/gpodder/GpodderPodcastTreeItem.cpp cf1b48c =
> src/services/gpodder/GpodderProvider.h 943d261 =
> src/services/gpodder/GpodderProvider.cpp 94546ec =
> src/services/gpodder/GpodderService.h 9462821 =
> src/services/gpodder/GpodderService.cpp 89a06ca =
> src/services/gpodder/GpodderServiceConfig.h 1939589 =
> src/services/gpodder/GpodderServiceConfig.cpp cdf6925 =
> src/services/gpodder/GpodderServiceModel.h d70cc1e =
> src/services/gpodder/GpodderServiceModel.cpp 5d5024a =
> src/services/gpodder/GpodderServiceSettings.h 4781452 =
> src/services/gpodder/GpodderServiceSettings.cpp 8b08324 =
> src/services/gpodder/GpodderSortFilterProxyModel.cpp 631402d =
> src/services/gpodder/GpodderTagTreeItem.h 08c52b4 =
> src/services/gpodder/GpodderTagTreeItem.cpp 2e3fc74 =
> src/services/gpodder/GpodderTreeItem.h 4e29362 =
> src/services/gpodder/GpodderTreeItem.cpp a772e4a =
> =
> Diff: http://git.reviewboard.kde.org/r/103195/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Lucas Gomes
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103195/">http://git.reviewboard.kde.org/r/103195/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Stefan</p>
<br />
<p>On November 21st, 2011, 12:38 a.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2011, 12:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Sorted #includes in files related to gpodder service & playlist \
sync. Done some clean-up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playlistmanager/SyncedPlaylist.h <span style="color: \
grey">(1f37508)</span></li>
<li>src/playlistmanager/SyncedPlaylist.cpp <span style="color: \
grey">(1546b7f)</span></li>
<li>src/playlistmanager/SyncedPodcast.h <span style="color: \
grey">(ea7f517)</span></li>
<li>src/playlistmanager/SyncedPodcast.cpp <span style="color: \
grey">(44a295b)</span></li>
<li>src/playlistmanager/file/KConfigSyncRelStore.h <span style="color: \
grey">(b2f1907)</span></li>
<li>src/playlistmanager/file/KConfigSyncRelStore.cpp <span style="color: \
grey">(517c6dc)</span></li>
<li>src/services/gpodder/GpodderPodcastMeta.h <span style="color: \
grey">(7fbad35)</span></li>
<li>src/services/gpodder/GpodderPodcastMeta.cpp <span style="color: \
grey">(90bd38f)</span></li>
<li>src/services/gpodder/GpodderPodcastRequestHandler.h <span style="color: \
grey">(9f0ced2)</span></li>
<li>src/services/gpodder/GpodderPodcastTreeItem.h <span style="color: \
grey">(96db070)</span></li>
<li>src/services/gpodder/GpodderPodcastTreeItem.cpp <span style="color: \
grey">(cf1b48c)</span></li>
<li>src/services/gpodder/GpodderProvider.h <span style="color: \
grey">(943d261)</span></li>
<li>src/services/gpodder/GpodderProvider.cpp <span style="color: \
grey">(94546ec)</span></li>
<li>src/services/gpodder/GpodderService.h <span style="color: \
grey">(9462821)</span></li>
<li>src/services/gpodder/GpodderService.cpp <span style="color: \
grey">(89a06ca)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.h <span style="color: \
grey">(1939589)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.cpp <span style="color: \
grey">(cdf6925)</span></li>
<li>src/services/gpodder/GpodderServiceModel.h <span style="color: \
grey">(d70cc1e)</span></li>
<li>src/services/gpodder/GpodderServiceModel.cpp <span style="color: \
grey">(5d5024a)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.h <span style="color: \
grey">(4781452)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: \
grey">(8b08324)</span></li>
<li>src/services/gpodder/GpodderSortFilterProxyModel.cpp <span style="color: \
grey">(631402d)</span></li>
<li>src/services/gpodder/GpodderTagTreeItem.h <span style="color: \
grey">(08c52b4)</span></li>
<li>src/services/gpodder/GpodderTagTreeItem.cpp <span style="color: \
grey">(2e3fc74)</span></li>
<li>src/services/gpodder/GpodderTreeItem.h <span style="color: \
grey">(4e29362)</span></li>
<li>src/services/gpodder/GpodderTreeItem.cpp <span style="color: \
grey">(a772e4a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103195/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic