From amarok-devel Mon Nov 21 11:42:47 2011 From: "Stefan Derkits" Date: Mon, 21 Nov 2011 11:42:47 +0000 To: amarok-devel Subject: Re: Review Request: Some clean-up and sort Message-Id: <20111121114247.23621.42694 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=amarok-devel&m=132187585030117 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1521837946154825482==" --===============1521837946154825482== Content-Type: multipart/alternative; boundary="===============1299888429810674958==" --===============1299888429810674958== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103195/#review8360 ----------------------------------------------------------- Ship it! Ship It! - Stefan Derkits On Nov. 21, 2011, 12:38 a.m., Lucas Gomes wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103195/ > ----------------------------------------------------------- > = > (Updated Nov. 21, 2011, 12:38 a.m.) > = > = > Review request for Amarok, Stefan Derkits and Bart Cerneels. > = > = > Description > ------- > = > Sorted #includes in files related to gpodder service & playlist sync. > Done some clean-up. > = > = > Diffs > ----- > = > src/playlistmanager/SyncedPlaylist.h 1f37508 = > src/playlistmanager/SyncedPlaylist.cpp 1546b7f = > src/playlistmanager/SyncedPodcast.h ea7f517 = > src/playlistmanager/SyncedPodcast.cpp 44a295b = > src/playlistmanager/file/KConfigSyncRelStore.h b2f1907 = > src/playlistmanager/file/KConfigSyncRelStore.cpp 517c6dc = > src/services/gpodder/GpodderPodcastMeta.h 7fbad35 = > src/services/gpodder/GpodderPodcastMeta.cpp 90bd38f = > src/services/gpodder/GpodderPodcastRequestHandler.h 9f0ced2 = > src/services/gpodder/GpodderPodcastTreeItem.h 96db070 = > src/services/gpodder/GpodderPodcastTreeItem.cpp cf1b48c = > src/services/gpodder/GpodderProvider.h 943d261 = > src/services/gpodder/GpodderProvider.cpp 94546ec = > src/services/gpodder/GpodderService.h 9462821 = > src/services/gpodder/GpodderService.cpp 89a06ca = > src/services/gpodder/GpodderServiceConfig.h 1939589 = > src/services/gpodder/GpodderServiceConfig.cpp cdf6925 = > src/services/gpodder/GpodderServiceModel.h d70cc1e = > src/services/gpodder/GpodderServiceModel.cpp 5d5024a = > src/services/gpodder/GpodderServiceSettings.h 4781452 = > src/services/gpodder/GpodderServiceSettings.cpp 8b08324 = > src/services/gpodder/GpodderSortFilterProxyModel.cpp 631402d = > src/services/gpodder/GpodderTagTreeItem.h 08c52b4 = > src/services/gpodder/GpodderTagTreeItem.cpp 2e3fc74 = > src/services/gpodder/GpodderTreeItem.h 4e29362 = > src/services/gpodder/GpodderTreeItem.cpp a772e4a = > = > Diff: http://git.reviewboard.kde.org/r/103195/diff/diff > = > = > Testing > ------- > = > = > Thanks, > = > Lucas Gomes > = > --===============1299888429810674958== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103195/

Ship it!

Ship It!
 








- Stefan




On November 21st, 2011, 12:38 a.m., Lucas Gomes wrote:







 
  

Review request for Amarok, Stefan Derkits and Bart Cerneels.
By Lucas Gomes.


Updated Nov. 21, 2011, 12:38 a.m.






Descripti=
on 
 
 
  
   Sorted #includes in files related to gpodder service & p=
laylist sync.
Done some clean-up.
  
 






Diffs=
 


 src/playlistmanager/SyncedPlaylist.h (1f37=
508)

 src/playlistmanager/SyncedPlaylist.cpp (15=
46b7f)

 src/playlistmanager/SyncedPodcast.h (ea7f5=
17)

 src/playlistmanager/SyncedPodcast.cpp (44a=
295b)

 src/playlistmanager/file/KConfigSyncRelStore.h (b2f1907)

 src/playlistmanager/file/KConfigSyncRelStore.cpp (517c6dc)

 src/services/gpodder/GpodderPodcastMeta.h =
(7fbad35)

 src/services/gpodder/GpodderPodcastMeta.cpp (9f0ced2)

 src/services/gpodder/GpodderPodcastTreeItem.h (96db070)

 src/services/gpodder/GpodderPodcastTreeItem.cpp (cf1b48c)

 src/services/gpodder/GpodderProvider.h (94=
3d261)

 src/services/gpodder/GpodderProvider.cpp (=
94546ec)

 src/services/gpodder/GpodderService.h (946=
2821)

 src/services/gpodder/GpodderService.cpp (8=
9a06ca)

 src/services/gpodder/GpodderServiceConfig.h (cdf6925)

 src/services/gpodder/GpodderServiceModel.h (d70cc1e)

 src/services/gpodder/GpodderServiceModel.cpp (5d5024a)

 src/services/gpodder/GpodderServiceSettings.h (4781452)

 src/services/gpodder/GpodderServiceSettings.cpp (8b08324)

 src/services/gpodder/GpodderSortFilterProxyModel.cpp (631402d)

 src/services/gpodder/GpodderTagTreeItem.h =
(08c52b4)

 src/services/gpodder/GpodderTagTreeItem.cpp (4e=
29362)

 src/services/gpodder/GpodderTreeItem.cpp (=
a772e4a)



View Diff

--===============1299888429810674958==-- --===============1521837946154825482== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============1521837946154825482==--