[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: [GSoC] Amarok integration with gpodder.net
From: "Bart Cerneels" <bart.cerneels () kde ! org>
Date: 2011-10-14 8:03:04
Message-ID: 20111014080304.10730.59852 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102844/#review7309
-----------------------------------------------------------
Ship it!
Testing and fixing code style. Will commit later.
- Bart Cerneels
On Oct. 13, 2011, 9:25 p.m., Lucas Gomes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102844/
> -----------------------------------------------------------
> =
> (Updated Oct. 13, 2011, 9:25 p.m.)
> =
> =
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> =
> =
> Description
> -------
> =
> The attached diff is the work done during this summer to integrate gpodde=
r.net web service with Amarok.
> Notice that this diff have only GPodder service related stuff and that yo=
u need to apply this =
> patch http://git.reviewboard.kde.org/r/102846/ before anything.
> =
> Added features:
> =
> Podcast subscription synchronisation.
> Podcast status synchronisation.
> Browse through podcasts suggested by gpodder.net.
> Browse through gpodder.net top recommended podcasts.
> =
> =
> Diffs
> -----
> =
> ChangeLog 14422b1 =
> src/core-impl/podcasts/gpodder/GpodderPodcastMeta.h PRE-CREATION =
> src/core-impl/podcasts/gpodder/GpodderPodcastMeta.cpp PRE-CREATION =
> src/core-impl/podcasts/gpodder/GpodderProvider.h PRE-CREATION =
> src/core-impl/podcasts/gpodder/GpodderProvider.cpp PRE-CREATION =
> src/services/gpodder/CMakeLists.txt 97f14b3 =
> src/services/gpodder/GpodderConfigWidget.ui PRE-CREATION =
> src/services/gpodder/GpodderService.h fac508a =
> src/services/gpodder/GpodderService.cpp e0cb02f =
> src/services/gpodder/GpodderServiceConfig.h PRE-CREATION =
> src/services/gpodder/GpodderServiceConfig.cpp PRE-CREATION =
> src/services/gpodder/GpodderServiceModel.h 1fbc90d =
> src/services/gpodder/GpodderServiceModel.cpp d899456 =
> src/services/gpodder/GpodderServiceSettings.h PRE-CREATION =
> src/services/gpodder/GpodderServiceSettings.cpp PRE-CREATION =
> src/services/gpodder/GpodderTreeItem.h 5698d5b =
> src/services/gpodder/GpodderTreeItem.cpp bfa216e =
> src/services/gpodder/amarok_service_gpodder_config.desktop PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/102844/diff/diff
> =
> =
> Testing
> -------
> =
> This patch is the result of git diff for the range of several commits pri=
or to HEAD, rebased on current master, and should build. Everything is work=
ing as expected and there aren't any known issues.
> =
> =
> Thanks,
> =
> Lucas Gomes
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102844/">http://git.reviewboard.kde.org/r/102844/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing and fixing code \
style. Will commit later.</pre> <br />
<p>- Bart</p>
<br />
<p>On October 13th, 2011, 9:25 p.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Oct. 13, 2011, 9:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached diff is the work done during this summer to integrate \
gpodder.net web service with Amarok. Notice that this diff have only GPodder service \
related stuff and that you need to apply this patch \
http://git.reviewboard.kde.org/r/102846/ before anything.
Added features:
Podcast subscription synchronisation.
Podcast status synchronisation.
Browse through podcasts suggested by gpodder.net.
Browse through gpodder.net top recommended podcasts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is the result of git diff for the range of several commits \
prior to HEAD, rebased on current master, and should build. Everything is working as \
expected and there aren't any known issues.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(14422b1)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderPodcastMeta.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderPodcastMeta.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderProvider.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderProvider.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/CMakeLists.txt <span style="color: \
grey">(97f14b3)</span></li>
<li>src/services/gpodder/GpodderConfigWidget.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderService.h <span style="color: \
grey">(fac508a)</span></li>
<li>src/services/gpodder/GpodderService.cpp <span style="color: \
grey">(e0cb02f)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceModel.h <span style="color: \
grey">(1fbc90d)</span></li>
<li>src/services/gpodder/GpodderServiceModel.cpp <span style="color: \
grey">(d899456)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderTreeItem.h <span style="color: \
grey">(5698d5b)</span></li>
<li>src/services/gpodder/GpodderTreeItem.cpp <span style="color: \
grey">(bfa216e)</span></li>
<li>src/services/gpodder/amarok_service_gpodder_config.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102844/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic