[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: [GSoC] Amarok integration with gpodder.net
From: "Bart Cerneels" <bart.cerneels () kde ! org>
Date: 2011-10-14 7:12:36
Message-ID: 20111014071236.4988.17480 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102846/#review7307
-----------------------------------------------------------
Ship it!
I'm committing the changes to XSPFPlaylist and M3UPlaylist separate.
ChangeLog
<http://git.reviewboard.kde.org/r/102846/#comment6388>
Newest changes go on top.
I will fix this when committing.
src/browsers/playlistbrowser/PodcastModel.h
<http://git.reviewboard.kde.org/r/102846/#comment6389>
These 2 functions need to go.
As far as I can tell you use them to access the master of a SyncedPodca=
st in data(). Using the master data needs to be implemented SyncedPodcast.
=
Will need to be fixed post-commit.
src/playlistmanager/SyncRelationStorage.cpp
<http://git.reviewboard.kde.org/r/102846/#comment6390>
This is a hack. No special cases allowed.
=
Will have to be fixed after committing.
- Bart Cerneels
On Oct. 13, 2011, 9:25 p.m., Lucas Gomes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102846/
> -----------------------------------------------------------
> =
> (Updated Oct. 13, 2011, 9:25 p.m.)
> =
> =
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> =
> =
> Description
> -------
> =
> The attached diff is the work done during this summer to integrate gpodde=
r.net web service with Amarok.
> Notice that this diff have only playlist synchronisation service related =
stuff.
> =
> =
> Diffs
> -----
> =
> ChangeLog 14422b1 =
> src/CMakeLists.txt 962070d =
> src/browsers/playlistbrowser/PlaylistBrowserModel.h 76ccb10 =
> src/browsers/playlistbrowser/PlaylistBrowserModel.cpp ff18d83 =
> src/browsers/playlistbrowser/PodcastModel.h ce1a86f =
> src/browsers/playlistbrowser/PodcastModel.cpp 4aad518 =
> src/browsers/playlistbrowser/QtGroupingProxy.cpp e0b4e7a =
> src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 2dcc0cd =
> src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp c64cb97 =
> src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 0a3c99a =
> src/core-impl/podcasts/sql/SqlPodcastMeta.h 0110911 =
> src/core-impl/podcasts/sql/SqlPodcastMeta.cpp e88bc9e =
> src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 83e9b99 =
> src/core/playlists/Playlist.h f88b070 =
> src/core/podcasts/PodcastMeta.h 21364b4 =
> src/core/podcasts/PodcastMeta.cpp fb82fa8 =
> src/main.cpp 7306e84 =
> src/playlistmanager/PlaylistManager.h 54d63b1 =
> src/playlistmanager/PlaylistManager.cpp 333ff17 =
> src/playlistmanager/SyncRelationStorage.h 2a2681d =
> src/playlistmanager/SyncRelationStorage.cpp b151243 =
> src/playlistmanager/SyncedPlaylist.h 54914c7 =
> src/playlistmanager/SyncedPlaylist.cpp c8383b5 =
> src/playlistmanager/SyncedPodcast.h PRE-CREATION =
> src/playlistmanager/SyncedPodcast.cpp PRE-CREATION =
> src/playlistmanager/file/KConfigSyncRelStore.h 4674f66 =
> src/playlistmanager/file/KConfigSyncRelStore.cpp a857593 =
> src/playlistmanager/file/PlaylistFileProvider.cpp 728030d =
> src/playlistmanager/sql/SqlPlaylist.cpp b2a9ca5 =
> =
> Diff: http://git.reviewboard.kde.org/r/102846/diff/diff
> =
> =
> Testing
> -------
> =
> This patch is the result of git diff for the range of several commits pri=
or to HEAD, rebased on current master, and should build. Everything is work=
ing as expected and there aren't any known issues.
> =
> =
> Thanks,
> =
> Lucas Gomes
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102846/">http://git.reviewboard.kde.org/r/102846/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm committing the \
changes to XSPFPlaylist and M3UPlaylist separate.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102846/diff/1/?file=38772#file38772line11" \
style="color: black; font-weight: bold; text-decoration: underline;">ChangeLog</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">11</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> * \
Possibility to browse through podcasts suggested by gpodder.net and through \
gpodder.net top recommended podcasts.</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Newest \
changes go on top. I will fix this when committing.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102846/diff/1/?file=38776#file38776line109" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/browsers/playlistbrowser/PodcastModel.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
PodcastModel : public PlaylistBrowserModel</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">109</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Playlists</span><span class="o">::</span><span class="n">PlaylistPtr</span> \
<span class="n">getPlaylist</span><span class="p">(</span> <span \
class="n">Playlists</span><span class="o">::</span><span class="n">PlaylistPtr</span> \
<span class="n">playlist</span> <span class="p">)</span> <span \
class="k">const</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These 2 \
functions need to go. As far as I can tell you use them to access the master of a \
SyncedPodcast in data(). Using the master data needs to be implemented SyncedPodcast.
Will need to be fixed post-commit.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102846/diff/1/?file=38792#file38792line25" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/playlistmanager/SyncRelationStorage.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">25</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a \
hack. No special cases allowed.
Will have to be fixed after committing.</pre>
</div>
<br />
<p>- Bart</p>
<br />
<p>On October 13th, 2011, 9:25 p.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Oct. 13, 2011, 9:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached diff is the work done during this summer to integrate \
gpodder.net web service with Amarok. Notice that this diff have only playlist \
synchronisation service related stuff.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is the result of git diff for the range of several commits \
prior to HEAD, rebased on current master, and should build. Everything is working as \
expected and there aren't any known issues.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(14422b1)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(962070d)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserModel.h <span style="color: \
grey">(76ccb10)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserModel.cpp <span style="color: \
grey">(ff18d83)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.h <span style="color: \
grey">(ce1a86f)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: \
grey">(4aad518)</span></li>
<li>src/browsers/playlistbrowser/QtGroupingProxy.cpp <span style="color: \
grey">(e0b4e7a)</span></li>
<li>src/core-impl/playlists/types/file/PlaylistFileSupport.cpp <span style="color: \
grey">(2dcc0cd)</span></li>
<li>src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp <span style="color: \
grey">(c64cb97)</span></li>
<li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: \
grey">(0a3c99a)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: \
grey">(0110911)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: \
grey">(e88bc9e)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: \
grey">(83e9b99)</span></li>
<li>src/core/playlists/Playlist.h <span style="color: grey">(f88b070)</span></li>
<li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(21364b4)</span></li>
<li>src/core/podcasts/PodcastMeta.cpp <span style="color: \
grey">(fb82fa8)</span></li>
<li>src/main.cpp <span style="color: grey">(7306e84)</span></li>
<li>src/playlistmanager/PlaylistManager.h <span style="color: \
grey">(54d63b1)</span></li>
<li>src/playlistmanager/PlaylistManager.cpp <span style="color: \
grey">(333ff17)</span></li>
<li>src/playlistmanager/SyncRelationStorage.h <span style="color: \
grey">(2a2681d)</span></li>
<li>src/playlistmanager/SyncRelationStorage.cpp <span style="color: \
grey">(b151243)</span></li>
<li>src/playlistmanager/SyncedPlaylist.h <span style="color: \
grey">(54914c7)</span></li>
<li>src/playlistmanager/SyncedPlaylist.cpp <span style="color: \
grey">(c8383b5)</span></li>
<li>src/playlistmanager/SyncedPodcast.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/playlistmanager/SyncedPodcast.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/playlistmanager/file/KConfigSyncRelStore.h <span style="color: \
grey">(4674f66)</span></li>
<li>src/playlistmanager/file/KConfigSyncRelStore.cpp <span style="color: \
grey">(a857593)</span></li>
<li>src/playlistmanager/file/PlaylistFileProvider.cpp <span style="color: \
grey">(728030d)</span></li>
<li>src/playlistmanager/sql/SqlPlaylist.cpp <span style="color: \
grey">(b2a9ca5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102846/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic