[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Refactoring of FileType, get Type from Database,
From: "Stefan Derkits" <stefan () derkits ! at>
Date: 2010-10-19 15:10:19
Message-ID: 20101019151019.1779.17391 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-19 15:00:10, Ian Monroe wrote:
> > what's the goal of this refactor?
The Goal was, to have an easy way to get all possible FileTypes in a suitable \
DataStructure. Take MetaQueryWidget as Example. If new FileTypes would have been \
added to FileType.h and used in the Database, there would also have been the need to \
add them there. Also I changed some Functions that worked by comparing the \
FileExtension to some known FileExtensions and create the corresponding FileType Enum \
to compare the fileExtension with the List of possibleFileTypes
- Stefan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100088/#review132
-----------------------------------------------------------
On 2010-10-18 23:57:36, Stefan Derkits wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100088/
> -----------------------------------------------------------
>
> (Updated 2010-10-18 23:57:36)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> Refactoring of FileType & some Changes that use the advantages of the new FileType \
> Class:
> -) Old enum FileType is now FileTypeEnum (still in there because it's needed to \
> create the new FileType Objects)
> -) Created new Class & some Helper Functions
> -) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
> -) Meta::SqlTrack.type() now gets it's Information from the Database instead of the \
> FileExtension
> Please give me your Feedback on this Patch.
> One thing I don't really like that much is the Constructor. But without the enums \
> the Constructor would have to use ugly Ints. An Option would be an additional \
> Constructor that takes a QString as Argument (e.g. I could think of \
> Amarok::FileType = "mp3"), and creates an Object by looking up the FileType in the \
> QStringList.
>
> Diffs
> -----
>
> shared/FileType.h 55c80b9
> shared/FileType.cpp PRE-CREATION
> src/CMakeLists.txt c55bb83
> src/browsers/CollectionTreeItemModelBase.cpp c25549b
> src/core-impl/collections/sqlcollection/CMakeLists.txt f530d67
> src/core-impl/collections/sqlcollection/SqlMeta.h 9434b03
> src/core-impl/collections/sqlcollection/SqlMeta.cpp 97969be
> src/core-impl/collections/support/MemoryFilter.cpp ecb92ff
> src/widgets/MetaQueryWidget.cpp 5316ec6
> tests/core-impl/collections/sqlcollection/CMakeLists.txt 93d24e3
> tests/synchronization/CMakeLists.txt e5df2df
> utilities/collectionscanner/CollectionScanner.cpp 033ea84
>
> Diff: http://git.reviewboard.kde.org/r/100088/diff
>
>
> Testing
> -------
>
> Tested in the App, found no wrong Behaviour
>
>
> Thanks,
>
> Stefan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100088/">http://git.reviewboard.kde.org/r/100088/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 19th, 2010, 3 p.m., <b>Ian Monroe</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what's \
the goal of this refactor?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Goal was, to have an \
easy way to get all possible FileTypes in a suitable DataStructure. Take \
MetaQueryWidget as Example. If new FileTypes would have been added to FileType.h and \
used in the Database, there would also have been the need to add them there. Also I \
changed some Functions that worked by comparing the FileExtension to some known \
FileExtensions and create the corresponding FileType Enum to compare the \
fileExtension with the List of possibleFileTypes</pre> <br />
<p>- Stefan</p>
<br />
<p>On October 18th, 2010, 11:57 p.m., Stefan Derkits wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated 2010-10-18 23:57:36</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Refactoring of FileType & some Changes that use the advantages of \
the new FileType Class:
-) Old enum FileType is now FileTypeEnum (still in there because it's needed to \
create the new FileType Objects)
-) Created new Class & some Helper Functions
-) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
-) Meta::SqlTrack.type() now gets it's Information from the Database instead of \
the FileExtension
Please give me your Feedback on this Patch.
One thing I don't really like that much is the Constructor. But without the enums \
the Constructor would have to use ugly Ints. An Option would be an additional \
Constructor that takes a QString as Argument (e.g. I could think of Amarok::FileType \
= "mp3"), and creates an Object by looking up the FileType in the \
QStringList.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in the App, found no wrong Behaviour</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/FileType.h <span style="color: grey">(55c80b9)</span></li>
<li>shared/FileType.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(c55bb83)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: \
grey">(c25549b)</span></li>
<li>src/core-impl/collections/sqlcollection/CMakeLists.txt <span style="color: \
grey">(f530d67)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: \
grey">(9434b03)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: \
grey">(97969be)</span></li>
<li>src/core-impl/collections/support/MemoryFilter.cpp <span style="color: \
grey">(ecb92ff)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(5316ec6)</span></li>
<li>tests/core-impl/collections/sqlcollection/CMakeLists.txt <span style="color: \
grey">(93d24e3)</span></li>
<li>tests/synchronization/CMakeLists.txt <span style="color: \
grey">(e5df2df)</span></li>
<li>utilities/collectionscanner/CollectionScanner.cpp <span style="color: \
grey">(033ea84)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100088/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic