[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Refactoring of FileType, get Type from Database,
From: "Ian Monroe" <ian.monroe () gmail ! com>
Date: 2010-10-19 15:09:14
Message-ID: 20101019150914.1693.37493 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100088/#review133
-----------------------------------------------------------
shared/FileType.h
<http://git.reviewboard.kde.org/r/100088/#comment117>
Add a comment that the enum must match up with s_fileTypeStrings
shared/FileType.cpp
<http://git.reviewboard.kde.org/r/100088/#comment116>
use QLatin1Literal
- Ian
On 2010-10-18 23:57:36, Stefan Derkits wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100088/
> -----------------------------------------------------------
>
> (Updated 2010-10-18 23:57:36)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> Refactoring of FileType & some Changes that use the advantages of the new FileType \
> Class:
> -) Old enum FileType is now FileTypeEnum (still in there because it's needed to \
> create the new FileType Objects)
> -) Created new Class & some Helper Functions
> -) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
> -) Meta::SqlTrack.type() now gets it's Information from the Database instead of the \
> FileExtension
> Please give me your Feedback on this Patch.
> One thing I don't really like that much is the Constructor. But without the enums \
> the Constructor would have to use ugly Ints. An Option would be an additional \
> Constructor that takes a QString as Argument (e.g. I could think of \
> Amarok::FileType = "mp3"), and creates an Object by looking up the FileType in the \
> QStringList.
>
> Diffs
> -----
>
> shared/FileType.h 55c80b9
> shared/FileType.cpp PRE-CREATION
> src/CMakeLists.txt c55bb83
> src/browsers/CollectionTreeItemModelBase.cpp c25549b
> src/core-impl/collections/sqlcollection/CMakeLists.txt f530d67
> src/core-impl/collections/sqlcollection/SqlMeta.h 9434b03
> src/core-impl/collections/sqlcollection/SqlMeta.cpp 97969be
> src/core-impl/collections/support/MemoryFilter.cpp ecb92ff
> src/widgets/MetaQueryWidget.cpp 5316ec6
> tests/core-impl/collections/sqlcollection/CMakeLists.txt 93d24e3
> tests/synchronization/CMakeLists.txt e5df2df
> utilities/collectionscanner/CollectionScanner.cpp 033ea84
>
> Diff: http://git.reviewboard.kde.org/r/100088/diff
>
>
> Testing
> -------
>
> Tested in the App, found no wrong Behaviour
>
>
> Thanks,
>
> Stefan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100088/">http://git.reviewboard.kde.org/r/100088/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100088/diff/1/?file=1147#file1147line27" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shared/FileType.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">enum</span> <span class="n">FileTypeEnum</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a \
comment that the enum must match up with s_fileTypeStrings</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100088/diff/1/?file=1148#file1148line24" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shared/FileType.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">using namespace Amarok;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">24</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">QStringList</span> <span class="n">FileType</span><span \
class="o">::</span><span class="n">m_fileTypeStrings</span> <span class="o">=</span> \
<span class="n">QStringList</span><span class="p">()</span> <span \
class="o"><<</span> <span class="n">i18n</span><span class="p">(</span><span \
class="s">"Unknown"</span><span class="p">)</span> <span \
class="o"><<</span> <span class="s">"mp3"</span> <span \
class="o"><<</span> <span class="s">"ogg"</span> <span \
class="o"><<</span> <span class="s">"flac"</span> <span \
class="o"><<</span> <span class="s">"mp4"</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use \
QLatin1Literal</pre> </div>
<br />
<p>- Ian</p>
<br />
<p>On October 18th, 2010, 11:57 p.m., Stefan Derkits wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated 2010-10-18 23:57:36</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Refactoring of FileType & some Changes that use the advantages of \
the new FileType Class:
-) Old enum FileType is now FileTypeEnum (still in there because it's needed to \
create the new FileType Objects)
-) Created new Class & some Helper Functions
-) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
-) Meta::SqlTrack.type() now gets it's Information from the Database instead of \
the FileExtension
Please give me your Feedback on this Patch.
One thing I don't really like that much is the Constructor. But without the enums \
the Constructor would have to use ugly Ints. An Option would be an additional \
Constructor that takes a QString as Argument (e.g. I could think of Amarok::FileType \
= "mp3"), and creates an Object by looking up the FileType in the \
QStringList.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in the App, found no wrong Behaviour</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/FileType.h <span style="color: grey">(55c80b9)</span></li>
<li>shared/FileType.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(c55bb83)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: \
grey">(c25549b)</span></li>
<li>src/core-impl/collections/sqlcollection/CMakeLists.txt <span style="color: \
grey">(f530d67)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: \
grey">(9434b03)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: \
grey">(97969be)</span></li>
<li>src/core-impl/collections/support/MemoryFilter.cpp <span style="color: \
grey">(ecb92ff)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(5316ec6)</span></li>
<li>tests/core-impl/collections/sqlcollection/CMakeLists.txt <span style="color: \
grey">(93d24e3)</span></li>
<li>tests/synchronization/CMakeLists.txt <span style="color: \
grey">(e5df2df)</span></li>
<li>utilities/collectionscanner/CollectionScanner.cpp <span style="color: \
grey">(033ea84)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100088/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic